This is the mail archive of the
ecos-discuss@sources.redhat.com
mailing list for the eCos project.
Re: New memory allocation debug feature
- From: Andrew Lunn <andrew at lunn dot ch>
- To: ?yvind Harboe <oyvind dot harboe at zylin dot com>
- Cc: ecos-discuss at sources dot redhat dot com
- Date: Thu, 17 Jun 2004 14:10:21 +0200
- Subject: Re: [ECOS] New memory allocation debug feature
- References: <1087469710.31564.11.camel@famine>
On Thu, Jun 17, 2004 at 12:55:11PM +0200, ?yvind Harboe wrote:
> Comments?
I would prefer the function to use the cyg_ prefix so it does not
polute the namespace.
You also need to provide an implementation in libtarget.a for when the
application does not have such a function. eg all the test programs
will not provide this function, so will fail to link when your new
option is enabled. So please add a week function which does nothing,
or maybe throws an CYG_FAIL().
It would also be nice if you used to same coding style for the patch
as for the rest of the file, ie { on the same line as the if etc.
Andrew
--
Before posting, please read the FAQ: http://ecos.sourceware.org/fom/ecos
and search the list archive: http://ecos.sourceware.org/ml/ecos-discuss