This is the mail archive of the ecos-discuss@sources.redhat.com mailing list for the eCos project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: bug about MPC8260 FEC driver?


On Mon, 2003-03-03 at 09:51, Paul Fine wrote:
> I have found that once I got the Cache control macro working, I could take 
> the lines of code in question out of the driver.  There is a note in the 
> fec driver which Gary mentions about a problem with the MPC860 data 
> cache.  Since we started with that driver to write this one, we ended up 
> leaving the code to disable the data cache.
> 
> Gary, please correct me if I am wrong about why that cache disabling code 
> is in the FEC driver.
> 

On the 8xx, the cache is not coherent wrt the CPM, thus these flushes
are required.  I believe that the 8260 does not have this problem, so 
they probably are wrong [or at least superfluous].

> As soon as a get a few free cycles, I will be putting together a patch for 
> some minor tweaks to the MPC8260 port.
> 
> At 06:51 AM 3/3/2003 -0700, Gary D. Thomas wrote:
> >On Sun, 2003-03-02 at 23:45, He HaiYang wrote:
> > > I use below command to get source tree.
> > >     cvs -z3 -d :pserver:anoncvs at sources dot redhat dot com:/cvs/ecos co -P ecos
> > > I think it is the lastest.
> > >
> > > In fact, I couldn't see other version of if_fec.c in its log.
> > >
> >
> >I missed the fact that you are using QUICC2, sorry.  That driver
> >was contributed and has not seen the same level of testing or
> >improvements.
> >
> >Try looking at devs/eth/powerpc/fec/current/src/if_fec.c to see how
> >to fix it up.
> >
> >Note: sending six (6) copies of the same email was not necessary.
> >
> > > ----- Original Message -----
> > > From: Gary D. Thomas
> > > To: he_hai_yang
> > > Cc: eCos Discussion
> > > Sent: Sunday, March 02, 2003 8:22 PM
> > > Subject: Re: [ECOS] bug about MPC8260 FEC driver?
> > >
> > >
> > > On Sat, 2003-03-01 at 22:54, he_hai_yang wrote:
> > > > in file ...\ecos\packages\devs\eth\powerpc\quicc2\current\src\if_fec.c
> > > > founction fec_eth_init():
> > > >
> > > > there are code :
> > > > if (cache_state) {
> > > >       HAL_DCACHE_DISABLE();
> > > >       HAL_DCACHE_INVALIDATE_ALL();
> > > >     }
> > > >
> > > > i think it should be:
> > > > if (cache_state) {
> > > >       HAL_DCACHE_SYNC();
> > > >       HAL_DCACHE_DISABLE();
> > > >     }
> > > >
> > > > If we call HAL_DCACHE_DISABLE() here, some modified in the ram will 
> > lose. In our test, once system goes here, the value of net_mem (in 
> > support.c) will change to 0.
> > > >
> > >
> > > What version of the code are you referring to?  I made major
> > > changes in how the data cache is handled in this driver a
> > > long time ago (back in October, 2002).
> > >
> > > Try updating to the latest CVS and see if you still have problems.
> >--
> >.--------------------------------------------------------.
> >|       Mind: Embedded Linux and eCos Development        |
> >|--------------------------------------------------------|
> >| Gary Thomas              email:  gary dot thomas at mind dot be   |
> >| Mind ( http://mind.be )  tel:    +1 (970) 229-1963     |
> >| gpg: http://www.chez-thomas.org/gary/gpg_key.asc       |
> >'--------------------------------------------------------'
> >
> >
> >--
> >Before posting, please read the FAQ: http://sources.redhat.com/fom/ecos
> >and search the list archive: http://sources.redhat.com/ml/ecos-discuss
> 
> Paul Fine
> Senior Member of Technical Staff
> Delphi Communication Systems, Inc.
> 2 Clock Tower Place Suite 310
> Maynard MA, 01754
> pfine at delcomsys dot com
> 
> 
> -- 
> Before posting, please read the FAQ: http://sources.redhat.com/fom/ecos
> and search the list archive: http://sources.redhat.com/ml/ecos-discuss



-- 
Before posting, please read the FAQ: http://sources.redhat.com/fom/ecos
and search the list archive: http://sources.redhat.com/ml/ecos-discuss


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]