Re: [PATCH 04 of 14] GCC Disable LTO support using correct configure option

[Bart van der Meulen <bartvdrmeulen at gmail dot com>]

2011/5/14 Yann E. MORIN <yann.morin.1998@anciens.enib.fr>:
> Bart, All,
>
> On Saturday 14 May 2011 16:01:31 Bart vdr. Meulen wrote:
>> # HG changeset patch
>> # User Bart vdr. Meulen <bartvdrmeulen@gmail.com>
>> # Date 1305381590 -7200
>> # Node ID 911dfdce436bcd2e60feddb1b0137499d62f0427
>> # Parent ?a2ccfa8aad41cf6ea6ed90bef287d435f2ab3c07
>> GCC Disable LTO support using correct configure option
>> LTO is enabled by default, so disable it explicit when not wanted
>>
>> Signed-off-by: Bart vdr. Meulen <bartvdrmeulen@gmail.com>
>> ---
>> ?scripts/build/cc/gcc.sh | ? ?6 +++---
>> ?1 files changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/scripts/build/cc/gcc.sh b/scripts/build/cc/gcc.sh
>> --- a/scripts/build/cc/gcc.sh
>> +++ b/scripts/build/cc/gcc.sh
>> @@ -235,10 +235,9 @@
>> ? ? ? ? ?extra_config+=("--with-cloog=no")
>> ? ? ?fi
>> ? ? ?if [ "${CT_CC_GCC_USE_LTO}" = "y" ]; then
>> + ? ? ? ?extra_config+=("--enable-lto")
>> ? ? ? ? ?extra_config+=("--with-libelf=${CT_COMPLIBS_DIR}")
>> - ? ? ? ?extra_config+=("--enable-lto")
>> ? ? ?elif [ "${CT_CC_GCC_HAS_LTO}" = "y" ]; then
>> - ? ? ? ?extra_config+=("--with-libelf=no")
>
> Why do you remove the above? If LTO is not needed, we sure don't want
> to link against libelf.
>

with-libelf is only used / checked when enable-lto is given, so no
need to specify this when you
disable lto

>> ? ? ? ? ?extra_config+=("--disable-lto")
>> ? ? ?fi
>>
>> @@ -486,9 +485,10 @@
>> ? ? ? ? ?extra_config+=("--with-cloog=no")
>> ? ? ?fi
>> ? ? ?if [ "${CT_CC_GCC_USE_LTO}" = "y" ]; then
>> + ? ? ? ?extra_config+=("--enable-lto")
>> ? ? ? ? ?extra_config+=("--with-libelf=${CT_COMPLIBS_DIR}")
>> ? ? ?elif [ "${CT_CC_GCC_HAS_LTO}" = "y" ]; then
>> - ? ? ? ?extra_config+=("--with-libelf=no")
>
> Ditto.
>
>> + ? ? ? ?extra_config+=("--disable-lto")
>
> Good catch!
>
>> ? ? ?fi
>>
>> ? ? ?if [ ${#host_libstdcxx_flags[@]} -ne 0 ]; then
>>
>
> Regards,
> Yann E. MORIN.
>
> --
> .-----------------.--------------------.------------------.--------------------.
> | ?Yann E. MORIN ?| Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
> | +33 662 376 056 | Software ?Designer | \ / CAMPAIGN ? ? | ?___ ? ? ? ? ? ? ? |
> | +33 223 225 172 `------------.-------: ?X ?AGAINST ? ? ?| ?\e/ ?There is no ?|
> | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL ? ?| ? v ? conspiracy. ?|
> '------------------------------^-------^------------------^--------------------'
>

--
For unsubscribe information see http://sourceware.org/lists.html#faq