This is the mail archive of the crossgcc@sourceware.org mailing list for the crossgcc project.

See the CrossGCC FAQ for lots more information.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [crosstool-ng] patch for glibc-2.3.6


Hello Julien!
Hello All!

On Friday 24 October 2008 11:47:27 Julien Dusser wrote:
> >> I still need an old glibc-2.3.6, so i patched it for make it working for 
> >> ppc 405 softfloat.
> >> Here are the patches.

Finally, I can look at the patches... See my comments in-line...

> glibc-2.3.6.patch
>   Index: patches/glibc/2.3.6/320-anchors-discarded-section.patch
> ===================================================================
> --- patches/glibc/2.3.6/320-anchors-discarded-section.patch?????(révision 0)
> +++ patches/glibc/2.3.6/320-anchors-discarded-section.patch?????(révision 0)
> @@ -0,0 +1,30 @@
> +Fixes:
> +
> +`.LANCHOR0' referenced in section `.text' of [...]/libc_pic.a(strtoul_l.os): defined in discarded section `.gnu.linkonce.r.__strtol_ul_max_tab' of [...]/libc_pic.a(strtoul_l.os)
> +...
> +
> +Add -fno-section-anchors as suggested in:
> +http://sourceware.org/ml/binutils/2006-08/msg00046.html

Unfortunately, that breaks non-powerpc builds. The ia64 sample also uses
that glibc version, and the build breaks as soon as installing the glibc
headers.

As stated in the gcc manual, -fsection-anchor (and its opposite) are not
supported by all architectures.

> --- patches/glibc/2.3.6/290-gcc-4.3-include.patch???????(révision 0)
> +++ patches/glibc/2.3.6/290-gcc-4.3-include.patch???????(révision 0)
> @@ -0,0 +1,40 @@
> +GCC trunk now has multiple internal headers directories, one
> +containing the self-contained GCC-provided headers and one containing
> +the <limits.h> (not self-contained but including libc's <limits.h> or
> +a fixed version thereof) and the fixed headers; more such directories
> +may be added in future.
> +
> +When glibc uses -nostdinc, it needs to use -isystem options for all
> +these internal directories. ?This patch teaches it about the
> +include-fixed directory (and is harmless with old GCC versions without
> +that directory).
> +
> +2007-03-18 ?Joseph Myers ?<joseph@codesourcery.com>
> +
> +???????* configure.in: Also pass -isystem option for GCC's include-fixed
> +???????directory.
> +???????* configure: Regenerate.

As far as I can tell, that one is valid, and already present for other
glibc versions.

I won't comment any further, as the build broke at least one existing sample.
Can you try to review this, please?

Thank you!

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +0/33 662376056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| --==< ^_^ >==-- `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
`------------------------------^-------^------------------^--------------------'


--
For unsubscribe information see http://sourceware.org/lists.html#faq


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]