This is the mail archive of the
cgen@sources.redhat.com
mailing list for the CGEN project.
Re: [dje@transmeta.com: ATTRIBUTE_UNUSED]
- To: "Frank Ch. Eigler" <fche at redhat dot com>, cgen at sources dot redhat dot com
- Subject: Re: [dje@transmeta.com: ATTRIBUTE_UNUSED]
- From: Dave Brolley <brolley at redhat dot com>
- Date: Thu, 24 Aug 2000 15:15:27 -0400
- Organization: Red Hat Canada, Inc
- References: <20000824150738.A18644@redhat.com>
Yes -- much better. I didn't know that one could use
ATTRIBUTE_UNUSED on a parameter that is actually used.
Dave
"Frank Ch. Eigler" wrote:
>
> Hi -
>
> Whaddaya think? It's your cleanup Doug is commenting upon.
>
> ----- Forwarded message from Doug Evans <dje@transmeta.com> -----
>
> > Date: Sun, 20 Aug 2000 08:28:03 -0700
> > From: Doug Evans <dje@transmeta.com>
> > To: cgen@sourceware.cygnus.com
> > Subject: ATTRIBUTE_UNUSED
> >
> > Instead of doing things like this:
> >
> > Index: m32r-dis.c
> > ===================================================================
> > RCS file: /cvs/src/src/opcodes/m32r-dis.c,v
> > retrieving revision 1.4
> > diff -c -p -r1.4 m32r-dis.c
> > *** m32r-dis.c 2000/02/24 16:19:36 1.4
> > --- m32r-dis.c 2000/08/20 15:24:28
> > *************** m32r_cgen_init_dis (cd)
> > *** 263,274 ****
> > --- 263,283 ----
> >
> > static void
> > print_normal (cd, dis_info, value, attrs, pc, length)
> > + #ifdef CGEN_PRINT_NORMAL
> > CGEN_CPU_DESC cd;
> > + #else
> > + CGEN_CPU_DESC cd ATTRIBUTE_UNUSED;
> > + #endif
> >
> > How about just
> >
> > - CGEN_CPU_DESC cd;
> > + CGEN_CPU_DESC cd ATTRIBUTE_UNUSED;
> >
>
> ----- End forwarded message -----
>
> --
> Frank Ch. Eigler // fche@redhat.com
> // fche@elastic.org
>
> -----------------------------------------------------------------
> Part 1.2Type: application/pgp-signature