This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch] [binutils][testsuite] Allow multiple lines of "as" in testsuite.


On Tue, Feb 26, 2019 at 8:05 AM Nick Clifton <nickc@redhat.com> wrote:
>
> Hi Matthew,
>
> > This is really confusing me -- I'm testing that target triple before and after
> > my patch and not seeing any of these messages.
>
> I must apologise - it was not you, it was me.  I had another patch that I was
> trying to test out at the same time, and this was causing the fake failures that
> I attributed to you.
>
> So, I apologise again, and I would confirm that your latest version of the patch is approved.

This breaks RHEL 7:

$ make check RUNTESTFLAGS=discard.exp
...
Running /export/gnu/import/git/sources/binutils-gdb/ld/testsuite/ld-discard/discard.exp
...
ERROR: (DejaGnu) proc "lmap x {{ }} {
        if { [string length $x] && [string length $as_additional_flags] } {
            append x " "
        }
        append x $as_additional_flags
        regsub {\[big_or_little_endian\]} $x  [big_or_little_endian] x
        expr {$x}
    }" does not exist.
The error code is NONE
The info on the error is:
invalid command name "lmap"
    while executing
"::tcl_unknown lmap x {{ }} {
        if { [string length $x] && [string length $as_additional_flags] } {
            append x " "
        }
        ap..."
    ("uplevel" body line 1)
    invoked from within
"uplevel 1 ::tcl_unknown $args"

=== ld Summary ===

/export/build/gnu/binutils/build-x86_64-linux/ld/ld-new 2.32.51.20190227

make[3]: *** [check-DEJAGNU] Error 1
make[3]: Leaving directory `/export/build/gnu/binutils/build-x86_64-linux/ld'
make[2]: *** [check-am] Error 2
make[2]: Leaving directory `/export/build/gnu/binutils/build-x86_64-linux/ld'
make[1]: *** [check-recursive] Error 1
make[1]: Leaving directory `/export/build/gnu/binutils/build-x86_64-linux/ld'
make: *** [check] Error 2

-- 
H.J.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]