This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] elfedit: Add --enable-x86-feature/--disable-x86-feature
- From: Nick Clifton <nickc at redhat dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>, binutils at sourceware dot org
- Date: Tue, 6 Nov 2018 16:48:57 +0000
- Subject: Re: [PATCH] elfedit: Add --enable-x86-feature/--disable-x86-feature
- References: <20181103134141.27217-1-hjl.tools@gmail.com>
Hi H.J.
> binutils/
>
> * doc/binutils.texi: Document --enable-x86-feature and
> --disable-x86-feature options for elfedit.
> * elfedit.c: Include "config.h" and <sys/mman.h>.
> (enable_x86_features): New.
> (disable_x86_features): Likewise.
> (update_gnu_property): Likewise.
> (elf_x86_feature): Likewise.
> (process_file): Call update_gnu_property on ET_EXEC or ET_DYN
> file.
> (command_line_switch): Add OPTION_ENABLE_X86_FEATURE and
> OPTION_DISABLE_X86_FEATURE.
> (options): Add--enable-x86-feature and --disable-x86-feature.
> (usage): Likewise.
> (main): Handle OPTION_ENABLE_X86_FEATURE and
> OPTION_DISABLE_X86_FEATURE.
>
> ld/
>
> * testsuite/config/default.exp (ELFEDIT): New.
> * testsuite/ld-elf/linux-x86.exp (elfedit_test): New proc.
> Run elfedit tests.
> * testsuite/ld-elf/x86-feature-1a.rd: New file.
> * testsuite/ld-elf/x86-feature-1b.rd: Likewise.
> * testsuite/ld-elf/x86-feature-1c.rd: Likewise.
> * testsuite/ld-elf/x86-feature-1d.rd: Likewise.
> * testsuite/ld-elf/x86-feature-1e.rd: Likewise.
Looks good to me.
Approved - please apply.
Cheers
Nick