This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH v2 0/7] x86: further template folding and misc improvements
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Jan Beulich <JBeulich at suse dot com>
- Cc: Binutils <binutils at sourceware dot org>
- Date: Thu, 13 Sep 2018 04:58:05 -0700
- Subject: Re: [PATCH v2 0/7] x86: further template folding and misc improvements
- References: <5B62A83102000078001DA1F0@prv1-mh.provo.novell.com> <5B8FC26202000078001E585D@prv1-mh.provo.novell.com> <CAMe9rOrsxvemOi-hPaQ=m3DjxrhoPadZq4xmHtpQet7Mmfk0Dw@mail.gmail.com> <5B9A26F302000078001E8171@prv1-mh.provo.novell.com>
On Thu, Sep 13, 2018 at 1:59 AM, Jan Beulich <JBeulich@suse.com> wrote:
>>>> On 12.09.18 at 23:19, <hjl.tools@gmail.com> wrote:
>> On Wed, Sep 5, 2018 at 4:47 AM, Jan Beulich <JBeulich@suse.com> wrote:
>>> 1: add code comment on deprecated status of pseudo-suffixes
>>> 2: improve operand reversal
>>> 3: fold ILP32 output of "opts" tests
>>> 4: extra operand reversal "opts" tests
>>> 5: use D attribute also for SIMD templates
>>> 6: also allow D on 3-operand insns
>>> 7: drop unnecessary {,No}Rex64
>>>
>>> Besides the new last patch the main change here compared to v1 is
>>> the splitting up of what is now patch 2. Patches 3 and 4 are therefore
>>> optional now. Patches 5 and 6 have been approved already, but
>>> can't go in without what is now patch 2.
>>
>> All looks good, except for
>>
>> https://sourceware.org/ml/binutils/2018-09/msg00026.html
>>
>> Please don't add new tests with the .s suffix. Please use {load} or
>> {store} instead.
>
> That's done in the earlier patch. I did submit the split parts in order
> to have everything available, but I'll simply omit that patch when
> committing (I take your response as "okay except for this one patch").
That is OK.
Thanks.
--
H.J.