This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
[PATCH] binutils/testsuite: Also consider `*-*-lynxos*' and `*-*-symbianelf*' targets ELF
- From: "Maciej W. Rozycki" <macro at mips dot com>
- To: <binutils at sourceware dot org>
- Date: Wed, 28 Mar 2018 21:59:01 +0100
- Subject: [PATCH] binutils/testsuite: Also consider `*-*-lynxos*' and `*-*-symbianelf*' targets ELF
These targets use the ELF format according to `bfd/config.bfd'.
binutils/
* testsuite/lib/binutils-common.exp (is_elf_format): Also return
1 for `*-*-lynxos*' and `*-*-symbianelf*' targets.
---
Hi,
Noticed in test log examination revealing missing results.
This does actually cause new failures for `arm-symbianelf', `i386-lynxos'
and `ppc-lynxos', however I don't think that's a reasonable excuse for
excluding these targets from ELF-specific testing. Individual failures
ought to be assessed on a case-by-case basis instead.
I didn't test obsolete `sh-symbianelf', it's not currently in my test
coverage (should it be?).
OK to apply?
Maciej
---
binutils/testsuite/lib/binutils-common.exp | 2 ++
1 file changed, 2 insertions(+)
binutils-test-is-elf-format-lynxos-symbian.diff
Index: binutils/binutils/testsuite/lib/binutils-common.exp
===================================================================
--- binutils.orig/binutils/testsuite/lib/binutils-common.exp 2018-02-23 14:13:48.000000000 +0000
+++ binutils/binutils/testsuite/lib/binutils-common.exp 2018-03-28 03:53:31.965331784 +0100
@@ -34,11 +34,13 @@ proc is_elf_format {} {
&& ![istarget *-*-irix5*]
&& ![istarget *-*-irix6*]
&& ![istarget *-*-linux*]
+ && ![istarget *-*-lynxos*]
&& ![istarget *-*-nacl*]
&& ![istarget *-*-netbsd*]
&& ![istarget *-*-openbsd*]
&& ![istarget *-*-rtems*]
&& ![istarget *-*-solaris2*]
+ && ![istarget *-*-symbianelf*]
&& ![istarget *-*-sysv4*]
&& ![istarget *-*-unixware*]
&& ![istarget *-*-wasm32*]