This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: Group terminating nop in P9
- From: Peter Bergner <bergner at vnet dot ibm dot com>
- To: Alan Modra <amodra at gmail dot com>
- Cc: binutils at sourceware dot org, Nicholas Piggin <npiggin at gmail dot com>, Segher Boessenkool <segher at kernel dot crashing dot org>
- Date: Thu, 8 Mar 2018 10:04:52 -0600
- Subject: Re: Group terminating nop in P9
- Authentication-results: sourceware.org; auth=none
- References: <20180305215458.3a04f68f@roar.ozlabs.ibm.com> <20180306071919.GM3812@bubble.grove.modra.org> <6ac0d030-174d-eac3-8b74-3b063129eac9@vnet.ibm.com> <20180308034838.GW3812@bubble.grove.modra.org> <20180308041112.GX3812@bubble.grove.modra.org>
On 3/7/18 10:11 PM, Alan Modra wrote:
> On Thu, Mar 08, 2018 at 02:18:38PM +1030, Alan Modra wrote:
>> On Wed, Mar 07, 2018 at 09:59:03AM -0600, Peter Bergner wrote:
>>> P9 does not have a group ending nop, unlike P8, P7, etc.
>>>
>>> That said, Segher just mentioned that when GCC is targetting P9,
>>> gas is generating a P8 group ending nop for a .p2align, which is
>>> a bug. I'll fix gas so that it doesn't do that.
>>
>> I already had a patch, now tested and committed, so no need to worry.
>
> Obviously not tested well enough. -mpower9 sets all the PPC_OPCODE_POWERn
> for n <= 9.
>
> * config/tc-ppc.c (ppc_handle_align): Correct last patch. Really
> don't emit a group terminating nop for power9. Simplify cpu
> tests.
Can you backport these to the 2.30 release branch? I'd like it there
to make picking that up easier for distros that are using 2.30. Thanks.
Peter