This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: Oh dear. I regret to inform you that commit 9e390558cef76767a98123994c422d0642d86cf8 might be unfortunate
- From: Alan Modra <amodra at gmail dot com>
- To: binutils at sourceware dot org
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 17 Jan 2018 21:26:26 +1030
- Subject: Re: Oh dear. I regret to inform you that commit 9e390558cef76767a98123994c422d0642d86cf8 might be unfortunate
- Authentication-results: sourceware.org; auth=none
- References: <9e390558cef76767a98123994c422d0642d86cf8-master-breakage@gdb-build>
On Wed, Jan 17, 2018 at 03:29:33AM -0500, gdb-buildbot@sergiodj.net wrote:
> My lords, ladies, gentlemen, members of the public.
>
> It is a matter of great regret and sadness to inform you that commit:
>
> PowerPC PLT stub tidy
> 9e390558cef76767a98123994c422d0642d86cf8
>
> might have made GDB unwell.
Hmm, not seen with my gcc-7 but this ought to cure the warning.
* elf64-ppc.c (ppc64_elf_build_stubs): Silence gcc warning.
diff --git a/bfd/elf64-ppc.c b/bfd/elf64-ppc.c
index 1b4404c..65cf7fe 100644
--- a/bfd/elf64-ppc.c
+++ b/bfd/elf64-ppc.c
@@ -13211,7 +13211,7 @@ ppc64_elf_build_stubs (struct bfd_link_info *info,
p += 4;
}
p = output_bctr (htab, htab->glink->owner, p);
- BFD_ASSERT (p - htab->glink->contents == GLINK_PLTRESOLVE_SIZE (htab));
+ BFD_ASSERT (p == htab->glink->contents + GLINK_PLTRESOLVE_SIZE (htab));
/* Build the .glink lazy link call stubs. */
indx = 0;
--
Alan Modra
Australia Development Lab, IBM