This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] [PowerPC] Use consistent types for holding insns, etc.


On Mon, Dec 04, 2017 at 08:41:56AM +1030, Alan Modra wrote:
> On Sun, Dec 03, 2017 at 11:10:15AM -0600, Peter Bergner wrote:
> > On 12/3/17 5:29 AM, Alan Modra wrote:
> > > Correct sign extension.  Fixes "FAIL: VLE relocations 3"
> > > 
> > > 	* ppc-opc.c (extract_li20): Rewrite.
> > 
> > Hmmm, I didn't see that failure.  Is there a secret configure option
> > needed to enable VLE?  Thanks for cleaning that up!
> 
> Configure for a powerpc-eabivle target.
> 
> Hmm, there doesn't seem to be any good reason for eabi tests to be
> treated specially.  I'll commit the following after a test run.
> 
> 	* testsuite/ld-powerpc/powerpc.exp (ppceabitests): Add -a32 -mbig
> 	to assembler options, and -melf32ppc to linker options.  Always
> 	run these tests.

Committed, and this gas testsuite fix too.

	* testsuite/gas/ppc/ppc.exp: Don't exclude VLE tests when little-endian.
	* testsuite/gas/ppc/efs.d: Add -mbig to assembler options.
	* testsuite/gas/ppc/efs2.d: Likewise.
	* testsuite/gas/ppc/lsp-checks.d: Likewise.
	* testsuite/gas/ppc/lsp.d: Likewise.
	* testsuite/gas/ppc/spe.d: Likewise.
	* testsuite/gas/ppc/spe2-checks.d: Likewise.
	* testsuite/gas/ppc/spe2.d: Likewise.
	* testsuite/gas/ppc/spe_ambiguous.d: Likewise.
	* testsuite/gas/ppc/vle-mult-ld-st-insns.d: Likewise.
	* testsuite/gas/ppc/vle-reloc.d: Likewise.
	* testsuite/gas/ppc/vle-simple-1.d: Likewise.
	* testsuite/gas/ppc/vle-simple-2.d: Likewise.
	* testsuite/gas/ppc/vle-simple-3.d: Likewise.
	* testsuite/gas/ppc/vle-simple-4.d: Likewise.
	* testsuite/gas/ppc/vle-simple-5.d: Likewise.
	* testsuite/gas/ppc/vle-simple-6.d: Likewise.
	* testsuite/gas/ppc/vle.d: Likewise.

diff --git a/gas/ChangeLog b/gas/ChangeLog
index 05dd5ee..b88af71 100644
--- a/gas/ChangeLog
+++ b/gas/ChangeLog
@@ -1,3 +1,24 @@
+2017-12-04  Alan Modra  <amodra@gmail.com>
+
+	* testsuite/gas/ppc/ppc.exp: Don't exclude VLE tests when little-endian.
+	* testsuite/gas/ppc/efs.d: Add -mbig to assembler options.
+	* testsuite/gas/ppc/efs2.d: Likewise.
+	* testsuite/gas/ppc/lsp-checks.d: Likewise.
+	* testsuite/gas/ppc/lsp.d: Likewise.
+	* testsuite/gas/ppc/spe.d: Likewise.
+	* testsuite/gas/ppc/spe2-checks.d: Likewise.
+	* testsuite/gas/ppc/spe2.d: Likewise.
+	* testsuite/gas/ppc/spe_ambiguous.d: Likewise.
+	* testsuite/gas/ppc/vle-mult-ld-st-insns.d: Likewise.
+	* testsuite/gas/ppc/vle-reloc.d: Likewise.
+	* testsuite/gas/ppc/vle-simple-1.d: Likewise.
+	* testsuite/gas/ppc/vle-simple-2.d: Likewise.
+	* testsuite/gas/ppc/vle-simple-3.d: Likewise.
+	* testsuite/gas/ppc/vle-simple-4.d: Likewise.
+	* testsuite/gas/ppc/vle-simple-5.d: Likewise.
+	* testsuite/gas/ppc/vle-simple-6.d: Likewise.
+	* testsuite/gas/ppc/vle.d: Likewise.
+
 2017-12-03  Jim Wilson  <jimw@sifive.com>
 
 	* doc/c-riscv.texi (RISC-V-Directives): Move @section immediately after
diff --git a/gas/testsuite/gas/ppc/efs.d b/gas/testsuite/gas/ppc/efs.d
index 5f1a847..f2ecad9 100644
--- a/gas/testsuite/gas/ppc/efs.d
+++ b/gas/testsuite/gas/ppc/efs.d
@@ -1,4 +1,4 @@
-#as: -a32 -mvle
+#as: -a32 -mbig -mvle
 #objdump: -d -Mefs -Mvle -Mefs2
 #name: Validate EFS instructions
 
diff --git a/gas/testsuite/gas/ppc/efs2.d b/gas/testsuite/gas/ppc/efs2.d
index 5914101..02fd26f 100644
--- a/gas/testsuite/gas/ppc/efs2.d
+++ b/gas/testsuite/gas/ppc/efs2.d
@@ -1,4 +1,4 @@
-#as: -a32 -mvle
+#as: -a32 -mbig -mvle
 #objdump: -d -Mvle -Mefs2
 #name: Validate EFS2 instructions
 
diff --git a/gas/testsuite/gas/ppc/lsp-checks.d b/gas/testsuite/gas/ppc/lsp-checks.d
index 99ccf54..39581e9 100644
--- a/gas/testsuite/gas/ppc/lsp-checks.d
+++ b/gas/testsuite/gas/ppc/lsp-checks.d
@@ -1,3 +1,3 @@
 #name: Test LSP operands checks
-#as: -a32 -mvle
+#as: -a32 -mbig -mvle
 #error-output: lsp-checks.l
diff --git a/gas/testsuite/gas/ppc/lsp.d b/gas/testsuite/gas/ppc/lsp.d
index f6c8458..ca45a36 100644
--- a/gas/testsuite/gas/ppc/lsp.d
+++ b/gas/testsuite/gas/ppc/lsp.d
@@ -1,4 +1,4 @@
-#as: -a32 -mvle
+#as: -a32 -mbig -mvle
 #objdump: -d -Mvle
 #name: Validate LSP instructions
 
diff --git a/gas/testsuite/gas/ppc/ppc.exp b/gas/testsuite/gas/ppc/ppc.exp
index b12fbd3..0d2941b 100644
--- a/gas/testsuite/gas/ppc/ppc.exp
+++ b/gas/testsuite/gas/ppc/ppc.exp
@@ -51,30 +51,28 @@ if { [istarget powerpc*-*-*] } then {
 	run_dump_test "476"
 	run_dump_test "a2"
 	run_dump_test "pr21303"
-	if { ![istarget powerpc*le-*-*] } then {
-	    run_dump_test "vle"
-	    run_dump_test "vle-reloc"
-	    run_dump_test "vle-simple-1"
-	    run_dump_test "vle-simple-2"
-	    run_dump_test "vle-simple-3"
-	    run_dump_test "vle-simple-4"
-	    run_dump_test "vle-simple-5"
-	    run_dump_test "vle-simple-6"
-	    run_dump_test "vle-mult-ld-st-insns"
+	run_dump_test "vle"
+	run_dump_test "vle-reloc"
+	run_dump_test "vle-simple-1"
+	run_dump_test "vle-simple-2"
+	run_dump_test "vle-simple-3"
+	run_dump_test "vle-simple-4"
+	run_dump_test "vle-simple-5"
+	run_dump_test "vle-simple-6"
+	run_dump_test "vle-mult-ld-st-insns"
 
-	    #fail expected until get_powerpc_dialect() patch not applied
-	    setup_xfail "*-*-*"
-	    run_dump_test "lsp"
-	    run_dump_test "lsp-checks"
-	    run_dump_test "efs"
-	    run_dump_test "efs2"
-	    run_dump_test "spe2"
-	    run_dump_test "spe2-checks"
-	    run_dump_test "spe"
+	#fail expected until get_powerpc_dialect() patch not applied
+	setup_xfail "*-*-*"
+	run_dump_test "lsp"
+	run_dump_test "lsp-checks"
+	run_dump_test "efs"
+	run_dump_test "efs2"
+	run_dump_test "spe2"
+	run_dump_test "spe2-checks"
+	run_dump_test "spe"
 
-	    setup_xfail "*-*-*"
-	    run_dump_test "spe_ambiguous"
-	}
+	setup_xfail "*-*-*"
+	run_dump_test "spe_ambiguous"
     }
 
     if { [istarget powerpc-*-*aix*] } then {
diff --git a/gas/testsuite/gas/ppc/spe.d b/gas/testsuite/gas/ppc/spe.d
index 7391028..caaa9e0 100644
--- a/gas/testsuite/gas/ppc/spe.d
+++ b/gas/testsuite/gas/ppc/spe.d
@@ -1,4 +1,4 @@
-#as: -a32 -mvle
+#as: -a32 -mbig -mvle
 #objdump: -d -Mspe
 #name: Validate SPE instructions
 
diff --git a/gas/testsuite/gas/ppc/spe2-checks.d b/gas/testsuite/gas/ppc/spe2-checks.d
index ec86e66..0acc27f 100644
--- a/gas/testsuite/gas/ppc/spe2-checks.d
+++ b/gas/testsuite/gas/ppc/spe2-checks.d
@@ -1,3 +1,3 @@
-#as: -a32 -mvle -mspe2
+#as: -a32 -mbig -mvle -mspe2
 #name: Test SPE2 operands checks
 #error-output: spe2-checks.l
diff --git a/gas/testsuite/gas/ppc/spe2.d b/gas/testsuite/gas/ppc/spe2.d
index e4c45de..25dbd2b 100644
--- a/gas/testsuite/gas/ppc/spe2.d
+++ b/gas/testsuite/gas/ppc/spe2.d
@@ -1,4 +1,4 @@
-#as: -a32 -mvle -mspe2
+#as: -a32 -mbig -mvle -mspe2
 #objdump: -d -Mspe2 -Mefs2
 #name: Validate SPE2 instructions
 
diff --git a/gas/testsuite/gas/ppc/spe_ambiguous.d b/gas/testsuite/gas/ppc/spe_ambiguous.d
index cdfb005..2e0b1d3 100644
--- a/gas/testsuite/gas/ppc/spe_ambiguous.d
+++ b/gas/testsuite/gas/ppc/spe_ambiguous.d
@@ -1,4 +1,4 @@
-#as: -a32 -mvle
+#as: -a32 -mbig -mvle
 #objdump: -d -Mspe
 #name: Validate SPE instructions
 
diff --git a/gas/testsuite/gas/ppc/vle-mult-ld-st-insns.d b/gas/testsuite/gas/ppc/vle-mult-ld-st-insns.d
index 2f9d6c7..ddaa694 100644
--- a/gas/testsuite/gas/ppc/vle-mult-ld-st-insns.d
+++ b/gas/testsuite/gas/ppc/vle-mult-ld-st-insns.d
@@ -1,4 +1,4 @@
-#as: -a32 -mvle -mregnames
+#as: -a32 -mbig -mvle -mregnames
 #objdump: -dr -Mvle
 #name: VLE Instructions for improving interrupt handler efficiency
 
diff --git a/gas/testsuite/gas/ppc/vle-reloc.d b/gas/testsuite/gas/ppc/vle-reloc.d
index dad153f..77d76f1 100644
--- a/gas/testsuite/gas/ppc/vle-reloc.d
+++ b/gas/testsuite/gas/ppc/vle-reloc.d
@@ -1,4 +1,4 @@
-#as: -a32 -mvle
+#as: -a32 -mbig -mvle
 #objdump: -dr -Mvle
 #name: VLE relocations
 
diff --git a/gas/testsuite/gas/ppc/vle-simple-1.d b/gas/testsuite/gas/ppc/vle-simple-1.d
index fee4054..43082c8 100644
--- a/gas/testsuite/gas/ppc/vle-simple-1.d
+++ b/gas/testsuite/gas/ppc/vle-simple-1.d
@@ -1,4 +1,4 @@
-#as: -a32 -mvle
+#as: -a32 -mbig -mvle
 #objdump: -dr -Mvle
 #name: VLE Simplified mnemonics 1
 
diff --git a/gas/testsuite/gas/ppc/vle-simple-2.d b/gas/testsuite/gas/ppc/vle-simple-2.d
index 291f6ea..a6cec75 100644
--- a/gas/testsuite/gas/ppc/vle-simple-2.d
+++ b/gas/testsuite/gas/ppc/vle-simple-2.d
@@ -1,4 +1,4 @@
-#as: -a32 -mvle
+#as: -a32 -mbig -mvle
 #objdump: -dr -Mvle
 #name: VLE Simplified mnemonics 2
 
diff --git a/gas/testsuite/gas/ppc/vle-simple-3.d b/gas/testsuite/gas/ppc/vle-simple-3.d
index 7b3ddb2..5218c85 100644
--- a/gas/testsuite/gas/ppc/vle-simple-3.d
+++ b/gas/testsuite/gas/ppc/vle-simple-3.d
@@ -1,4 +1,4 @@
-#as: -a32 -mvle
+#as: -a32 -mbig -mvle
 #objdump: -dr -Mvle
 #name: VLE Simplified mnemonics 3
 
diff --git a/gas/testsuite/gas/ppc/vle-simple-4.d b/gas/testsuite/gas/ppc/vle-simple-4.d
index 9d9ae38..f66733e 100644
--- a/gas/testsuite/gas/ppc/vle-simple-4.d
+++ b/gas/testsuite/gas/ppc/vle-simple-4.d
@@ -1,4 +1,4 @@
-#as: -a32 -mvle
+#as: -a32 -mbig -mvle
 #objdump: -dr -Mvle
 #name: VLE Simplified mnemonics 4
 
diff --git a/gas/testsuite/gas/ppc/vle-simple-5.d b/gas/testsuite/gas/ppc/vle-simple-5.d
index 8e98145..817df09 100644
--- a/gas/testsuite/gas/ppc/vle-simple-5.d
+++ b/gas/testsuite/gas/ppc/vle-simple-5.d
@@ -1,4 +1,4 @@
-#as: -a32 -mvle
+#as: -a32 -mbig -mvle
 #objdump: -dr -Mvle
 #name: VLE Simplified mnemonics 5
 
diff --git a/gas/testsuite/gas/ppc/vle-simple-6.d b/gas/testsuite/gas/ppc/vle-simple-6.d
index 64c9a2d..9ea87b2 100644
--- a/gas/testsuite/gas/ppc/vle-simple-6.d
+++ b/gas/testsuite/gas/ppc/vle-simple-6.d
@@ -1,4 +1,4 @@
-#as: -a32 -mvle
+#as: -a32 -mbig -mvle
 #objdump: -dr -Mvle
 #name: VLE Simplified mnemonics 6
 
diff --git a/gas/testsuite/gas/ppc/vle.d b/gas/testsuite/gas/ppc/vle.d
index dcc2cc3..6661ff4 100644
--- a/gas/testsuite/gas/ppc/vle.d
+++ b/gas/testsuite/gas/ppc/vle.d
@@ -1,4 +1,4 @@
-#as: -a32 -mvle
+#as: -a32 -mbig -mvle
 #objdump: -dr -Mvle
 #name: Validate VLE instructions
 


-- 
Alan Modra
Australia Development Lab, IBM


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]