This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] [PowerPC] Use consistent types for holding insns, etc.


On Sun, Dec 03, 2017 at 11:10:15AM -0600, Peter Bergner wrote:
> On 12/3/17 5:29 AM, Alan Modra wrote:
> > Correct sign extension.  Fixes "FAIL: VLE relocations 3"
> > 
> > 	* ppc-opc.c (extract_li20): Rewrite.
> 
> Hmmm, I didn't see that failure.  Is there a secret configure option
> needed to enable VLE?  Thanks for cleaning that up!

Configure for a powerpc-eabivle target.

Hmm, there doesn't seem to be any good reason for eabi tests to be
treated specially.  I'll commit the following after a test run.

	* testsuite/ld-powerpc/powerpc.exp (ppceabitests): Add -a32 -mbig
	to assembler options, and -melf32ppc to linker options.  Always
	run these tests.

diff --git a/ld/testsuite/ld-powerpc/powerpc.exp b/ld/testsuite/ld-powerpc/powerpc.exp
index ef3b718..a01d060 100644
--- a/ld/testsuite/ld-powerpc/powerpc.exp
+++ b/ld/testsuite/ld-powerpc/powerpc.exp
@@ -257,29 +257,29 @@ set ppc64elftests {
 }
 
 set ppceabitests {
-    {"VLE multiple segments 1" "-T vle-multiseg-1.ld" ""
-     "-mregnames -mvle" {vle-multiseg.s}
+    {"VLE multiple segments 1" "-melf32ppc -T vle-multiseg-1.ld" ""
+     "-a32 -mbig -mregnames -mvle" {vle-multiseg.s}
     {{readelf "-l" vle-multiseg-1.d}} "vle-multiseg-1"}
-    {"VLE multiple segments 2" "-T vle-multiseg-2.ld" ""
-     "-mregnames -mvle" {vle-multiseg.s}
+    {"VLE multiple segments 2" "-melf32ppc -T vle-multiseg-2.ld" ""
+     "-a32 -mbig -mregnames -mvle" {vle-multiseg.s}
     {{readelf "-l" vle-multiseg-2.d}} "vle-multiseg-2"}
-    {"VLE multiple segments 3" "-T vle-multiseg-3.ld" ""
-     "-mregnames -mvle" {vle-multiseg.s}
+    {"VLE multiple segments 3" "-melf32ppc -T vle-multiseg-3.ld" ""
+     "-a32 -mbig -mregnames -mvle" {vle-multiseg.s}
     {{readelf "-l" vle-multiseg-3.d}} "vle-multiseg-3"}
-    {"VLE multiple segments 4" "-T vle-multiseg-4.ld" ""
-     "-mregnames -mvle" {vle-multiseg.s}
+    {"VLE multiple segments 4" "-melf32ppc -T vle-multiseg-4.ld" ""
+     "-a32 -mbig -mregnames -mvle" {vle-multiseg.s}
     {{readelf "-l" vle-multiseg-4.d}} "vle-multiseg-4"}
-    {"VLE multiple segments 5" "-T vle-multiseg-5.ld" ""
-     "-mregnames -mvle" {vle-multiseg.s}
+    {"VLE multiple segments 5" "-melf32ppc -T vle-multiseg-5.ld" ""
+     "-a32 -mbig -mregnames -mvle" {vle-multiseg.s}
     {{readelf "-l" vle-multiseg-5.d}} "vle-multiseg-5"}
-    {"VLE relocations 1" "-T vle.ld" ""
-     "-mvle" {vle-reloc-1.s vle-reloc-def-1.s}
+    {"VLE relocations 1" "-melf32ppc -T vle.ld" ""
+     "-a32 -mbig -mvle" {vle-reloc-1.s vle-reloc-def-1.s}
     {{objdump "-Mvle -d" vle-reloc-1.d}} "vle-reloc-1"}
-    {"VLE relocations 2" "-T vle.ld" ""
-     "-mvle" {vle-reloc-2.s vle-reloc-def-2.s}
+    {"VLE relocations 2" "-melf32ppc -T vle.ld" ""
+     "-a32 -mbig -mvle" {vle-reloc-2.s vle-reloc-def-2.s}
     {{objdump "-Mvle -d" vle-reloc-2.d}} "vle-reloc-2"}
-    {"VLE relocations 3" "-T vle.ld" ""
-     "-mvle" {vle-reloc-3.s vle-reloc-def-3.s}
+    {"VLE relocations 3" "-melf32ppc -T vle.ld" ""
+     "-a32 -mbig -mvle" {vle-reloc-3.s vle-reloc-def-3.s}
     {{objdump "-Mvle -d" vle-reloc-3.d}} "vle-reloc-3"}
 }
 
@@ -332,9 +332,7 @@ if [ supports_ppc64 ] then {
 
 run_dump_test "tlsld32"
 
-if { [istarget "powerpc*-eabi*"] } {
-    run_ld_link_tests $ppceabitests
-}
+run_ld_link_tests $ppceabitests
 
 run_dump_test "plt1"
 run_dump_test "sdabase"

-- 
Alan Modra
Australia Development Lab, IBM


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]