This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] x86: don't omit disambiguating suffixes from "fi*"
On Fri, Nov 24, 2017 at 6:37 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Thu, Nov 23, 2017 at 7:46 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
>> On Thu, Nov 23, 2017 at 7:43 AM, Jan Beulich <JBeulich@suse.com> wrote:
>>>>>> On 23.11.17 at 14:41, <hjl.tools@gmail.com> wrote:
>>>> On Mon, Nov 20, 2017 at 5:07 AM, Jan Beulich <JBeulich@suse.com> wrote:
>>>>> "fi*" typically come in two (loads/stores: three) flavors, distinguished
>>>>> by the suffix. Don't omit the 's' one when disassembling, and for
>>>>> consistency also add the missing 's' ones for the testsuite inputs, even
>>>>> if this will become a requirement only later.
>>>>
>>>> If we want to disallow them without 's' nor 'l' in the future, we need an
>>>> assembler option to allow them. Before we do that, please keep
>>>> the test without 's' nor 'l' for now. We can move them to a new test
>>>> later. OK with this change.
>>>
>>> Just so I understand you right: You want the testsuite *.s files to be
>>> left alone, i.e. as offered ...
>>>
>>>>> ---
>>>>> I'd be fine with dropping the testsuite input changes here, moving them
>>>>> to the patch where they will become a requirement (still WIP).
>>>
>>> ... here?
>>
>> Yes. But it is OK to add the new 's'/'l' tests without removing existing ones.
>>
>
> I got:
>
> FAIL: i386 SSE without AVX equivalent
> FAIL: x86-64 SSE without AVX equivalent
> FAIL: x86-64 (ILP32) SSE without AVX equivalent
>
> on Linux/x86-64. Please fix them.
This is what I checked in.
--
H.J.
From afdbae4dffd7d7a0e911b9be961d6784715daa9d Mon Sep 17 00:00:00 2001
From: "H.J. Lu" <hjl.tools@gmail.com>
Date: Sun, 26 Nov 2017 08:28:25 -0800
Subject: [PATCH] gas: Update x86 sse-noavx tests
This fixed:
FAIL: i386 SSE without AVX equivalent
FAIL: x86-64 SSE without AVX equivalent
FAIL: x86-64 (ILP32) SSE without AVX equivalent
on x86-64.
* testsuite/gas/i386/sse-noavx.s: Add tests for fisttps and
fisttpl.
* testsuite/gas/i386/x86-64-sse-noavx.s: Likewise.
* testsuite/gas/i386/ilp32/x86-64-sse-noavx.d: Updated.
* testsuite/gas/i386/sse-noavx.d: Likewise.
* testsuite/gas/i386/x86-64-sse-noavx.d: Likewise.
---
gas/ChangeLog | 9 +++++++++
gas/testsuite/gas/i386/ilp32/x86-64-sse-noavx.d | 1 +
gas/testsuite/gas/i386/sse-noavx.d | 1 +
gas/testsuite/gas/i386/sse-noavx.s | 2 ++
gas/testsuite/gas/i386/x86-64-sse-noavx.d | 1 +
gas/testsuite/gas/i386/x86-64-sse-noavx.s | 2 ++
6 files changed, 16 insertions(+)
diff --git a/gas/ChangeLog b/gas/ChangeLog
index 13fee06986..79c5b87772 100644
--- a/gas/ChangeLog
+++ b/gas/ChangeLog
@@ -1,3 +1,12 @@
+2017-11-26 H.J. Lu <hongjiu.lu@intel.com>
+
+ * testsuite/gas/i386/sse-noavx.s: Add tests for fisttps and
+ fisttpl.
+ * testsuite/gas/i386/x86-64-sse-noavx.s: Likewise.
+ * testsuite/gas/i386/ilp32/x86-64-sse-noavx.d: Updated.
+ * testsuite/gas/i386/sse-noavx.d: Likewise.
+ * testsuite/gas/i386/x86-64-sse-noavx.d: Likewise.
+
2017-11-24 Jim Wilson <jimw@sifive.com>
* write.h (FAKE_LABEL_CHAR): Expand comment.
diff --git a/gas/testsuite/gas/i386/ilp32/x86-64-sse-noavx.d b/gas/testsuite/gas/i386/ilp32/x86-64-sse-noavx.d
index cb9fa05b29..4a24c33443 100644
--- a/gas/testsuite/gas/i386/ilp32/x86-64-sse-noavx.d
+++ b/gas/testsuite/gas/i386/ilp32/x86-64-sse-noavx.d
@@ -17,6 +17,7 @@ Disassembly of section .text:
[ ]*[a-f0-9]+: 66 0f 2c dc cvttpd2pi %xmm4,%mm3
[ ]*[a-f0-9]+: 0f 2c dc cvttps2pi %xmm4,%mm3
[ ]*[a-f0-9]+: df 08 fisttps \(%rax\)
+[ ]*[a-f0-9]+: df 08 fisttps \(%rax\)
[ ]*[a-f0-9]+: db 08 fisttpl \(%rax\)
[ ]*[a-f0-9]+: dd 08 fisttpll \(%rax\)
[ ]*[a-f0-9]+: 0f ae e8 lfence
diff --git a/gas/testsuite/gas/i386/sse-noavx.d b/gas/testsuite/gas/i386/sse-noavx.d
index d422909150..0fbb874cca 100644
--- a/gas/testsuite/gas/i386/sse-noavx.d
+++ b/gas/testsuite/gas/i386/sse-noavx.d
@@ -15,6 +15,7 @@ Disassembly of section .text:
[ ]*[a-f0-9]+: 66 0f 2c dc cvttpd2pi %xmm4,%mm3
[ ]*[a-f0-9]+: 0f 2c dc cvttps2pi %xmm4,%mm3
[ ]*[a-f0-9]+: df 08 fisttps \(%eax\)
+[ ]*[a-f0-9]+: df 08 fisttps \(%eax\)
[ ]*[a-f0-9]+: db 08 fisttpl \(%eax\)
[ ]*[a-f0-9]+: dd 08 fisttpll \(%eax\)
[ ]*[a-f0-9]+: 0f ae e8 lfence
diff --git a/gas/testsuite/gas/i386/sse-noavx.s b/gas/testsuite/gas/i386/sse-noavx.s
index 900c9e5122..42d1c3dd36 100644
--- a/gas/testsuite/gas/i386/sse-noavx.s
+++ b/gas/testsuite/gas/i386/sse-noavx.s
@@ -10,6 +10,8 @@ _start:
cvttpd2pi %xmm4,%mm3
cvttps2pi %xmm4,%mm3
fisttp (%eax)
+ fisttps (%eax)
+ fisttpl (%eax)
fisttpll (%eax)
lfence
maskmovq %mm7,%mm0
diff --git a/gas/testsuite/gas/i386/x86-64-sse-noavx.d b/gas/testsuite/gas/i386/x86-64-sse-noavx.d
index d500a20bb2..4d75f246cc 100644
--- a/gas/testsuite/gas/i386/x86-64-sse-noavx.d
+++ b/gas/testsuite/gas/i386/x86-64-sse-noavx.d
@@ -16,6 +16,7 @@ Disassembly of section .text:
[ ]*[a-f0-9]+: 66 0f 2c dc cvttpd2pi %xmm4,%mm3
[ ]*[a-f0-9]+: 0f 2c dc cvttps2pi %xmm4,%mm3
[ ]*[a-f0-9]+: df 08 fisttps \(%rax\)
+[ ]*[a-f0-9]+: df 08 fisttps \(%rax\)
[ ]*[a-f0-9]+: db 08 fisttpl \(%rax\)
[ ]*[a-f0-9]+: dd 08 fisttpll \(%rax\)
[ ]*[a-f0-9]+: 0f ae e8 lfence
diff --git a/gas/testsuite/gas/i386/x86-64-sse-noavx.s b/gas/testsuite/gas/i386/x86-64-sse-noavx.s
index 69e7e96792..f1795ea5c1 100644
--- a/gas/testsuite/gas/i386/x86-64-sse-noavx.s
+++ b/gas/testsuite/gas/i386/x86-64-sse-noavx.s
@@ -11,6 +11,8 @@ _start:
cvttpd2pi %xmm4,%mm3
cvttps2pi %xmm4,%mm3
fisttp (%rax)
+ fisttps (%rax)
+ fisttpl (%rax)
fisttpll (%rax)
lfence
maskmovq %mm7,%mm0
--
2.14.3