Re: [PATCH] x86: don't omit disambiguating suffixes from "fi*"

["H.J. Lu" <hjl dot tools at gmail dot com>]

On Mon, Nov 20, 2017 at 5:07 AM, Jan Beulich <JBeulich@suse.com> wrote:
> "fi*" typically come in two (loads/stores: three) flavors, distinguished
> by the suffix. Don't omit the 's' one when disassembling, and for
> consistency also add the missing 's' ones for the testsuite inputs, even
> if this will become a requirement only later.

If we want to disallow them without 's' nor 'l' in the future, we need an
assembler option to allow them.  Before we do that,  please keep
the test without 's' nor 'l'  for now.  We can move them to a new test
later.   OK with this change.

> ---
> I'd be fine with dropping the testsuite input changes here, moving them
> to the patch where they will become a requirement (still WIP).
>
> gas/
> 2017-11-20  Jan Beulich  <jbeulich@suse.com>
>
>
>         * testsuite/gas/i386/opcode.s: Add 's' suffix to "fi*" not having
>         any suffix so far.
>         * testsuite/gas/i386/sse-noavx.s: Likewise.
>         * testsuite/gas/i386/sse3.s: Likewise.
>         * testsuite/gas/i386/x86-64-sse-noavx.s: Likewise.
>         * testsuite/gas/i386/x86-64-sse3.s: Likewise.
>         * testsuite/gas/i386/intel.d, testsuite/gas/i386/opcode.d,
>         testsuite/gas/i386/opcode-suffix.d, testsuite/gas/i386/sse3.d,
>         testsuite/gas/i386/sse-noavx.d, testsuite/gas/i386/x86-64-sse3.d,
>         testsuite/gas/i386/x86-64-sse-noavx.d,
>         testsuite/gas/i386/ilp32/x86-64-sse3.d,
>         testsuite/gas/i386/ilp32/x86-64-sse-noavx.d: Adjust expectations.
>
>         * testsuite/gas/i386/x86-64-reg-bad.{s,l}: New.
>         * testsuite/gas/i386/i386.exp: Run new test.
>
> opcodes/
> 2017-11-20  Jan Beulich  <jbeulich@suse.com>
>
>         * i386-dis.c (float_mem): Add suffixes to fi* in the "de" and
>         "df" groups.
>

Thanks.

-- 
H.J.