This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH v2] x86: reject further invalid AVX-512 masking constructs
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Jan Beulich <JBeulich at suse dot com>
- Cc: Binutils <binutils at sourceware dot org>
- Date: Thu, 23 Nov 2017 05:07:41 -0800
- Subject: Re: [PATCH v2] x86: reject further invalid AVX-512 masking constructs
- Authentication-results: sourceware.org; auth=none
- References: <5A16AC85020000780019144F@prv-mh.provo.novell.com>
On Thu, Nov 23, 2017 at 2:09 AM, Jan Beulich <JBeulich@suse.com> wrote:
> For one the register type used for masking should be validated. And then
> we shouldn't accept input producing encodings which will #UD when
> executed, as is the case when EVEX.Z is set while EVEX.AAA is zero.
>
> gas/
> 2017-11-23 Jan Beulich <jbeulich@suse.com>
>
> * config/tc-i386.c (check_VecOperations): Check register type
> for masking. Quote the actual register name in the respective
> diagnostic. Check {z} wasn't specified on its own.
> * testsuite/gas/i386/inval-avx512f.s,
> testsuite/gas/i386/x86-64-inval-avx512f.s: Add further bad
> masking tests.
> * testsuite/gas/i386/inval-avx512f.l,
> testsuite/gas/i386/x86-64-inval-avx512f.l: Adjust expectations.
This is OK.
Thanks.
--
H.J.