This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: PR22451, strip no longer works on older object files
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Alan Modra <amodra at gmail dot com>
- Cc: Binutils <binutils at sourceware dot org>
- Date: Mon, 20 Nov 2017 05:50:04 -0800
- Subject: Re: PR22451, strip no longer works on older object files
- Authentication-results: sourceware.org; auth=none
- References: <20171120134051.GV10905@bubble.grove.modra.org>
On Mon, Nov 20, 2017 at 5:40 AM, Alan Modra <amodra@gmail.com> wrote:
> Setting SHF_GROUP unconditionally on rel/rela sections associated with
> SHF_GROUP sections fails badly with objcopy/strip and ld -r if the
> input file SHT_GROUP section didn't specify the rel/rela sections.
> This patch rearranges where SHF_GROUP is set for rel/rela sections.
>
> PR 22451
> PR 22460
> * elf.c (_bfd_elf_init_reloc_shdr): Delete "sec_hdr" parameter
> and leave rel_hdr->sh_flags zero. Update calls.
> (bfd_elf_set_group_contents): Check input rel/rela SHF_GROUP
> flag when !gas before adding rel/rela section to group. Set
> output rel/rela SHF_GROUP flags.
>
Can we add an assembler command-line option to get back the old
behavior? It can be used to generate a testcase for this patch. It
may be useful in other places.
--
H.J.