This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 4/4] ld: Add ldlang_check_relro_region/update lang_find_relro_sections_1

From: Alan Modra <amodra at gmail dot com>
To: "H.J. Lu" <hjl dot tools at gmail dot com>
Cc: binutils at sourceware dot org
Date: Mon, 13 Nov 2017 10:42:35 +1030
Subject: Re: [PATCH 4/4] ld: Add ldlang_check_relro_region/update lang_find_relro_sections_1
Authentication-results: sourceware.org; auth=none
References: <20171112173151.16388-1-hjl.tools@gmail.com> <20171112173151.16388-5-hjl.tools@gmail.com>

On Sun, Nov 12, 2017 at 09:31:51AM -0800, H.J. Lu wrote:
> 	(ldlang_check_relro_region): New function.
> 	(lang_find_relro_sections_1): Add an argument for pointer to

This is a nitpick, but most other functions that have a
lang_statement_union_type* argument have it as the first parameter.
It obviously doesn't matter, but I think it would be nicer for
consistency if you kept the same parameter order here.

Other than that, the patch series looks fine to me.

-- 
Alan Modra
Australia Development Lab, IBM

Follow-Ups:
- Re: [PATCH 4/4] ld: Add ldlang_check_relro_region/update lang_find_relro_sections_1
  - From: H.J. Lu

References:
- [PATCH 0/4] Generate text-only LOAD segment similar to GNU_RELRO
  - From: H.J. Lu
- [PATCH 4/4] ld: Add ldlang_check_relro_region/update lang_find_relro_sections_1
  - From: H.J. Lu

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]