This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] tile: Remove the __tls_get_addr check from gc_mark_hook
- From: Alan Modra <amodra at gmail dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: binutils at sourceware dot org
- Date: Wed, 18 Oct 2017 09:49:23 +1030
- Subject: Re: [PATCH] tile: Remove the __tls_get_addr check from gc_mark_hook
- Authentication-results: sourceware.org; auth=none
- References: <20171017212736.GB32374@intel.com>
On Tue, Oct 17, 2017 at 02:27:36PM -0700, H.J. Lu wrote:
> Reference to __tls_get_addr is created by check_relocs. Since check_relocs
> is called after garbage collection now, the __tls_get_addr check should be
> removed from gc_mark_hook.
What happens if the only reference to __tls_get_addr is an implicit
one via TLS_GD_CALL? Imagine a static --gc-sections link with
__tls_get_addr in its own section. Shouldn't you instead be creating
the __tls_get_addr reference in gcc_mark_hook?
--
Alan Modra
Australia Development Lab, IBM