Re: [RFC] .fill does not accept forward labels

[Andreas Krebbel <krebbel at linux dot vnet dot ibm dot com>]

On Wed, Oct 11, 2017 at 12:56:46PM +0100, Maciej W. Rozycki wrote:
>  Your updated patch seems to have been garbled in transit; I have fixed 
> the breakage however and applied it regardless, and gave it a quick shot.  

Next try then:

diff --git a/gas/testsuite/gas/all/fill-1.d b/gas/testsuite/gas/all/fill-1.d
new file mode 100644
index 0000000..0402245
--- /dev/null
+++ b/gas/testsuite/gas/all/fill-1.d
@@ -0,0 +1,8 @@
+#objdump: -s -j .data
+#name: fill test with forward labels
+
+.*: +file format .*
+
+Contents of section .data:
+ [^ ]* 0a0a0d0d 0b0b0d0d .*
+
diff --git a/gas/testsuite/gas/all/fill-1.s b/gas/testsuite/gas/all/fill-1.s
index e72cbf1..4981c39 100644
--- a/gas/testsuite/gas/all/fill-1.s
+++ b/gas/testsuite/gas/all/fill-1.s
@@ -1,5 +1,7 @@
-	.text
-	.fill (2f-1f), 1, 0x90
+	.data
+	.dc.w 0x0a0a
+	.fill (2f-1f), 1, 0x0d
 1:
-        .word 42
+	.dc.w 0x0b0b
 2:
+	.dc.w 0x0d0d
diff --git a/gas/testsuite/gas/all/gas.exp b/gas/testsuite/gas/all/gas.exp
index 93e31da..1810ef4 100644
--- a/gas/testsuite/gas/all/gas.exp
+++ b/gas/testsuite/gas/all/gas.exp
@@ -487,4 +487,4 @@ run_dump_test "org-4"
 run_dump_test "org-5"
 run_dump_test "org-6"
 
-gas_test "fill-1.s" "" "" "test .fill forward label references"
+run_dump_test "fill-1"

> It revealed failures for these targets:
> 
> hppa-hp-hpux10  +FAIL: fill test with forward labels
> hppa64-hp-hpux11.23  +FAIL: fill test with forward labels
> ia64-vms  +FAIL: fill test with forward labels
> sh-pe  +FAIL: fill test with forward labels
> tic4x-coff  +FAIL: fill test with forward labels
> tic54x-coff  +FAIL: fill test with forward labels

I don't see these failure with my tests. Could you please post the gas.log output.

Bye,

-Andreas-