This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC] .fill does not accept forward labels


On Mon, 9 Oct 2017, Andreas Krebbel wrote:

> diff --git a/gas/testsuite/gas/all/fill-1.s b/gas/testsuite/gas/all/fill-1.s
> new file mode 100644
> index 0000000..92d495a
> --- /dev/null
> +++ b/gas/testsuite/gas/all/fill-1.s
> @@ -0,0 +1,5 @@
> +	.text
> +	.fill (2f-1f), 1, 0x90
> +1:
> +        nop
> +2:

 Have you verified your new test case? -- I think not all targets have a 
`nop' instruction mnemonic.  I reckon this is already handled in other 
tests that need to emit a piece of code across all targets, although ISTM 
here you could have just used a portable data directive instead, such as 
`.word', as it doesn't really matter for the objective of this test what 
is there between the two labels.

  Maciej


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]