This is the mail archive of the
mailing list for the binutils project.
Re: [PATCH 0/4] Fix issues with Linux core PRPSINFO note definitions
- From: Sergio Durigan Junior <sergiodj at redhat dot com>
- To: "Maciej W. Rozycki" <macro at imgtec dot com>
- Cc: <binutils at sourceware dot org>, <gdb-patches at sourceware dot org>, Pedro Alves <palves at redhat dot com>, Djordje Todorovic <djordje dot todorovic at rt-rk dot com>
- Date: Fri, 22 Sep 2017 22:09:56 -0400
- Subject: Re: [PATCH 0/4] Fix issues with Linux core PRPSINFO note definitions
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=sergiodj at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 85B9CC057F93
- References: <alpine.DEB.firstname.lastname@example.org>
On Friday, September 22 2017, Maciej W. Rozycki wrote:
> This patch series addresses problems with Linux core PRPSINFO note
> definitions, discovered in the course of Djordje's MIPS PID extraction
> patch review. See individual patch descriptions for details.
> These changes have passed binutils regression testing against my usual
> targets (for the BFD part) and also native GDB regression testing with the
> `x86_64-linux-gnu' target and the `mips-linux-gnu' n64 target (for the GDB
> part, and the `gcore' command in particular).
> OK to apply?
Aside from a small nit on patch #3, I really like the direction you
chose on this patch. I am not a binutils maintainer and not a GDB
global maintainer, so I cannot approve it, but it does look good to me
and makes the existing code more logical and simpler to follow.
I also like the fact that you removed the responsibility that GDB had to
decide which prpsinfo structure it would use. That's something I
remember struggling with when I was hacking the initial patch, and I'm
glad this patch solves it.
GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible