This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Call _close_and_cleanup in bfd_close_all_done

From: Alan Modra <amodra at gmail dot com>
To: "H.J. Lu" <hjl dot tools at gmail dot com>
Cc: Binutils <binutils at sourceware dot org>
Date: Thu, 31 Aug 2017 10:34:18 +0930
Subject: Re: [PATCH] Call _close_and_cleanup in bfd_close_all_done
Authentication-results: sourceware.org; auth=none
References: <20170829190531.GA2862@intel.com> <20170830064928.GI3368@bubble.grove.modra.org> <CAMe9rOqhzx9Sn6qB_W5vWA9hfUnsZbppvf=VpMzb8MujEXAFHA@mail.gmail.com> <20170830231921.GC28143@bubble.grove.modra.org>

On Thu, Aug 31, 2017 at 08:49:21AM +0930, Alan Modra wrote:
> I'm testing the following fix.
> 
> 	* opncls.c (bfd_close_all_done): Don't call bfd_cache_close
> 	before _close_and_cleanup.  Call iovec->bclose after.
> 	(bfd_close): Remove code common to, and call bfd_close_all_done.

Now committed.  The test run showed breakage of all x86 non-ELF
targets.

../bfd/.libs/libbfd.a(elfxx-x86.o): In function `_bfd_x86_elf_link_hash_table_create':
/home/alan/src/binutils-gdb/bfd/elfxx-x86.c:269: undefined reference to `elf64_r_info'
/home/alan/src/binutils-gdb/bfd/elfxx-x86.c:270: undefined reference to `elf64_r_sym'

-- 
Alan Modra
Australia Development Lab, IBM

References:
- [PATCH] Call _close_and_cleanup in bfd_close_all_done
  - From: H.J. Lu
- Re: [PATCH] Call _close_and_cleanup in bfd_close_all_done
  - From: Alan Modra
- Re: [PATCH] Call _close_and_cleanup in bfd_close_all_done
  - From: H.J. Lu
- Re: [PATCH] Call _close_and_cleanup in bfd_close_all_done
  - From: Alan Modra

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]