This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

[PATCH][gold] Fix offset calculation when applying AArch64 TLSDESC relocations.

From: Igor Kudrin <ikudrin at accesssoftek dot com>
To: "binutils at sourceware dot org" <binutils at sourceware dot org>
Cc: Jing Yu <jingyu at google dot com>, Han Shen <shenhan at google dot com>, "\"Cary Coutant\"" <ccoutant at gmail dot com>
Date: Fri, 25 Aug 2017 14:10:15 +0000
Subject: [PATCH][gold] Fix offset calculation when applying AArch64 TLSDESC relocations.
Authentication-results: sourceware.org; auth=none

Hi,

If a custom linker script with an unexpected relative layout of .got
and .got.plt sections was used, gold might produce a wrong offset
when applying R_AARCH64_TLSDESC_* relocations.

This patch fixes the issue by calculating "got_tlsdesc_offset"
in a more direct way.

Best regards,
Igor Kudrin
C++ Developer, Access Softek, Inc.

---
gold/ChangeLog

	* aarch64.cc (Target_aarch64::Relocate::relocate_tls):
	Make got_tlsdesc_offset signed and fix its calculation.
	* testsuite/Makefile.am (aarch64_tlsdesc): New test.
	* testsuite/Makefile.in: Regenerate.
	* testsuite/aarch64_tlsdesc.s: New test source file.
	* testsuite/aarch64_tlsdesc.sh: New test script.
	* testsuite/aarch64_tlsdesc.t: New test linker script.

Attachment: gold-aarch64-tlsdesc-offset.patch.txt
Description: gold-aarch64-tlsdesc-offset.patch.txt

Follow-Ups:
- Re: [PATCH][gold] Fix offset calculation when applying AArch64 TLSDESC relocations.
  - From: Jing Yu via binutils
- Re: [PATCH][gold] Fix offset calculation when applying AArch64 TLSDESC relocations.
  - From: Cary Coutant

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]