This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] [PowerPC VLE] Add LSP instructions support
- From: Alan Modra <amodra at gmail dot com>
- To: Alexander Fedotov <alfedotov at gmail dot com>
- Cc: binutils at sourceware dot org
- Date: Mon, 21 Aug 2017 19:07:21 +0930
- Subject: Re: [PATCH] [PowerPC VLE] Add LSP instructions support
- Authentication-results: sourceware.org; auth=none
- References: <CAN8C2CrsdPKHuEA_KWoT12sQpx71cS2hQYZJ73LZBBheRY8_6g@mail.gmail.com>
On Sun, Aug 20, 2017 at 12:15:11AM +0300, Alexander Fedotov wrote:
> This patch adds LSP instructions support to PowerPC VLE. Based against
> current master branch.
This is OK with a few fixes.
> +2017-08-19 Alexander Fedotov <alexander.fedotov@nxp.com>
> + Edmar Wienskoski <edmar.wienskoski@nxp.com
> +
> + *gas/testsuite/gas/ppc/lsp-checks.d: New test
> + *gas/testsuite/gas/ppc/lsp-checks.l: New
> + *gas/testsuite/gas/ppc/lsp-checks.s: New
> + *gas/testsuite/gas/ppc/lsp.d: New
> + *gas/testsuite/gas/ppc/lsp.s: New
> + *gas/testsuite/gas/ppc/ppc.exp: Run new tests.
> +
Files in a ChangeLog should be relative to the ChangeLog, and there
should be a space after the '*'.
> +static unsigned long
> +insert_evuimm2_ex0 (unsigned long insn,
> + long value,
> + ppc_cpu_t dialect ATTRIBUTE_UNUSED,
> + const char **errmsg)
Formatting here and on other new functions is broken. It should be
static unsigned long
insert_evuimm2_ex0 (unsigned long insn,
long value,
ppc_cpu_t dialect ATTRIBUTE_UNUSED,
const char **errmsg)
Maybe the tabs were eaten by your email client? There are other minor
whitespace issue too. If you add the following to you binutils
.git/config under the [core] heading, git will show them to you
whitespace = indent-with-non-tab,space-before-tab,trailing-space
--
Alan Modra
Australia Development Lab, IBM