This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [committed, PATCH] PR ld/21923: Replace --rpath with -Wl,--rpath


On Tue, Aug 8, 2017 at 7:10 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Tue, Aug 8, 2017 at 4:36 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
>> On Tue, Aug 8, 2017 at 3:39 PM, Alan Modra <amodra@gmail.com> wrote:
>>> On Tue, Aug 08, 2017 at 02:17:05PM -0700, H.J. Lu wrote:
>>>> --- a/ld/configure.ac
>>>> +++ b/ld/configure.ac
>>>> @@ -470,7 +470,7 @@ EMULATION_LIBPATH=$all_libpath
>>>>  AC_SUBST(EMULATION_LIBPATH)
>>>>
>>>>  if test x${enable_static} = xno; then
>>>> -  TESTBFDLIB="--rpath ../bfd/.libs ../bfd/.libs/libbfd.so"
>>>> +  TESTBFDLIB="-Wl,--rpath ../bfd/.libs ../bfd/.libs/libbfd.so"
>>>>  else
>>>>    TESTBFDLIB="../bfd/.libs/libbfd.a"
>>>>  fi
>>>
>>> Does that actually work?  I thought you needed to write -Wl options
>>> without the spaces..
>>>
>>> TESTBFDLIB="-Wl,--rpath,../bfd/.libs,../bfd/.libs/libbfd.so"
>>>
>>
>> Yes, a `,' is needed.  For some reason, it passed the tests without it.
>>
>>
>
> I got lucky. -Wl,--rpath ../bfd/.libs works:

> I will add '.' anyway.
>

I am backporting these 2 patches to 2.29 branch.

-- 
H.J.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]