This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH][AArch64] Skip IFUNC relocations in debug sections
- From: Nick Clifton <nickc at redhat dot com>
- To: Szabolcs Nagy <szabolcs dot nagy at arm dot com>, Binutils <binutils at sourceware dot org>
- Cc: nd at arm dot com
- Date: Wed, 9 Aug 2017 17:54:36 +0100
- Subject: Re: [PATCH][AArch64] Skip IFUNC relocations in debug sections
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx05.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx05.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=nickc at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 1036537B7BC
- References: <598AEC83.2010600@arm.com>
Hi Szabolcs,
+ if ((input_section->flags & SEC_ALLOC) == 0)
+ {
+ /* Dynamic relocs are not propagated for SEC_DEBUGGING
+ sections because such sections are not SEC_ALLOC and
+ thus ld.so will not process them. */
+ if ((input_section->flags & SEC_DEBUGGING) != 0)
+ return bfd_reloc_ok;
+ abort ();
+ }
+ else if (h->plt.offset == (bfd_vma) -1)
I would much rather that you replaced the call to abort() with calls
to _bfd_error_handler and bfd_set_error and then return FALSE. (As
is done further down in the code). I know that you did not put this
call to abort in in the first place, but since you are fixing up this
bit of code, it would be great to remove the abort at the same time.
Cheers
Nick