This is the mail archive of the mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v3] Add configure flag to enable gnu hash style by default.

On Wed, Jul 19, 2017 at 01:03:45PM +0000, Romain Geissler wrote:
> Hi,
> This is the third version of my hash style changes.
> Changes since v2:
>  - Use by default "both" hash style for targets *-*-gnu*, *-*-linux*, and *-*-nacl*, and "sysv" otherwise.
> As for the previous patch, only the "ld" changes could be properly regression-tested (x86_64 linux).
> Since I don't have other targets, would you please test on the ones you have ?

You don't need hardware to test other binutils targets.  Just
configure with --target=, "make", and "make check".  Some tests won't
run without a C compiler and library installed, but a lot do.

Anyway, I ran the testsuite for you.  frv-linux needs some testsuite
updates.  It's possible some other binutils patch caused the failures,
but please attempt to fix regressions caused by your patch.  Also,
mips targets fail ld tests with ".gnu.hash is incompatible with the
MIPS ABI".  You'll need to exclude mips*-*-* from targets defaulting
to both hash styles.  (See ld/emultempl/mipself.em)

Alan Modra
Australia Development Lab, IBM

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]