This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[committed, PATCH] i386: Add tests for PIE with undefined weak symbol


	* testsuite/ld-i386/i386.exp: Run pie1 and pie1-nacl.
	* testsuite/ld-i386/pie1-nacl.d: New file.
	* testsuite/ld-i386/pie1.d: Likewise.
	* testsuite/ld-i386/pie1.s: Likewise.
---
 ld/ChangeLog                     |  7 +++++++
 ld/testsuite/ld-i386/i386.exp    |  2 ++
 ld/testsuite/ld-i386/pie1-nacl.d | 18 ++++++++++++++++++
 ld/testsuite/ld-i386/pie1.d      | 17 +++++++++++++++++
 ld/testsuite/ld-i386/pie1.s      |  5 +++++
 5 files changed, 49 insertions(+)
 create mode 100644 ld/testsuite/ld-i386/pie1-nacl.d
 create mode 100644 ld/testsuite/ld-i386/pie1.d
 create mode 100644 ld/testsuite/ld-i386/pie1.s

diff --git a/ld/ChangeLog b/ld/ChangeLog
index 735fdeb33b..ba03ae40cc 100644
--- a/ld/ChangeLog
+++ b/ld/ChangeLog
@@ -1,5 +1,12 @@
 2017-07-17  H.J. Lu  <hongjiu.lu@intel.com>
 
+	* testsuite/ld-i386/i386.exp: Run pie1 and pie1-nacl.
+	* testsuite/ld-i386/pie1-nacl.d: New file.
+	* testsuite/ld-i386/pie1.d: Likewise.
+	* testsuite/ld-i386/pie1.s: Likewise.
+
+2017-07-17  H.J. Lu  <hongjiu.lu@intel.com>
+
 	PR ld/21782
 	* testsuite/ld-x86-64/pie3-nacl.d: New file.
 	* testsuite/ld-x86-64/pie3.d: Likewise.
diff --git a/ld/testsuite/ld-i386/i386.exp b/ld/testsuite/ld-i386/i386.exp
index 6c53046193..ba39fc132e 100644
--- a/ld/testsuite/ld-i386/i386.exp
+++ b/ld/testsuite/ld-i386/i386.exp
@@ -434,6 +434,8 @@ run_dump_test "property-x86-shstk3a"
 run_dump_test "property-x86-shstk3b"
 run_dump_test "property-x86-shstk4"
 run_dump_test "property-x86-shstk5"
+run_dump_test "pie1"
+run_dump_test "pie1-nacl"
 
 if { !([istarget "i?86-*-linux*"]
        || [istarget "i?86-*-gnu*"]
diff --git a/ld/testsuite/ld-i386/pie1-nacl.d b/ld/testsuite/ld-i386/pie1-nacl.d
new file mode 100644
index 0000000000..aafd6a7ef5
--- /dev/null
+++ b/ld/testsuite/ld-i386/pie1-nacl.d
@@ -0,0 +1,18 @@
+#source: pie1.s
+#as: --32
+#ld: -pie -melf_i386 -z relro
+#objdump: -dw --sym
+#target: i?86-*-nacl* x86_64-*-nacl*
+
+.*: +file format .*
+
+SYMBOL TABLE:
+#...
+10020000 l     O .got.plt	0+ _GLOBAL_OFFSET_TABLE_
+#...
+
+Disassembly of section .text:
+
+0+ <_start>:
+ +0:	8d 80 00 00 fe ef    	lea    -0x10020000\(%eax\),%eax
+#pass
diff --git a/ld/testsuite/ld-i386/pie1.d b/ld/testsuite/ld-i386/pie1.d
new file mode 100644
index 0000000000..fb35342321
--- /dev/null
+++ b/ld/testsuite/ld-i386/pie1.d
@@ -0,0 +1,17 @@
+#as: --32
+#ld: -pie -melf_i386 -z relro
+#objdump: -dw --sym
+#notarget: i?86-*-nacl* x86_64-*-nacl*
+
+.*: +file format .*
+
+SYMBOL TABLE:
+#...
+0+2000 l     O .got.plt	0+ _GLOBAL_OFFSET_TABLE_
+#...
+
+Disassembly of section .text:
+
+0+129 <_start>:
+ +129:	8d 80 00 e0 ff ff    	lea    -0x2000\(%eax\),%eax
+#pass
diff --git a/ld/testsuite/ld-i386/pie1.s b/ld/testsuite/ld-i386/pie1.s
new file mode 100644
index 0000000000..b4d1d73d6b
--- /dev/null
+++ b/ld/testsuite/ld-i386/pie1.s
@@ -0,0 +1,5 @@
+	.text
+	.global _start
+	.weak foo
+_start:
+	leal	foo@GOTOFF(%eax), %eax
-- 
2.13.0


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]