This is the mail archive of the
mailing list for the binutils project.
Re: [PATCH] Always define referenced __start_SECNAME/__stop_SECNAME
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Alan Modra <amodra at gmail dot com>
- Cc: Binutils <binutils at sourceware dot org>
- Date: Mon, 12 Jun 2017 17:18:58 -0700
- Subject: Re: [PATCH] Always define referenced __start_SECNAME/__stop_SECNAME
- Authentication-results: sourceware.org; auth=none
- References: <20170610224649.GA12339@gmail.com> <20170612233208.GA8406@bubble.grove.modra.org>
On Mon, Jun 12, 2017 at 4:32 PM, Alan Modra <email@example.com> wrote:
> On Sat, Jun 10, 2017 at 03:46:49PM -0700, H.J. Lu wrote:
>> This patch changes linker to always define referenced __start_SECNAME and
>> __stop_SECNAME if the input section name is the same output section name,
>> which is always true for orphaned sections, and SECNAME is a C identifier.
> I think this change is reasonable.
>> Also __start_SECNAME and __stop_SECNAME symbols are marked as hidden by
>> ELF linker.
> Why is this necessary? Also, you make another change in behaviour
It is to make sure that __start_SECNAME and __stop_SECNAME
symbols for section SECNAME in different modules are unique.
> that you don't mention: __start and __stop symbols were previously
> defined by ld -Ur, not just at final link. You'll need to modify
Is there a testcase for this behavior?
> lang_set_startof to keep this behaviour (and be careful to not change
> .startof. and .sizeof. syms).
I have an updated patch to address: