This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] ELF/BFD: Hold the number of internal static relocs in `->reloc_count'


On Jun 02 2017, "Maciej W. Rozycki" <macro@imgtec.com> wrote:

>  I'll go with:
>
>       size = o->reloc_count;
>       size *= sizeof (Elf_Internal_Rela);
>
> then if you don't mind.  I find explicit casts worsen code readability.

The cast makes the intent explicit though.  Without it the next one
touching this code will likely combine the expressions again.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]