This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] X86: Add SHL/SAL ModRM.reg == 6 alias

>>> On 23.05.17 at 16:51, <hjl.tools@gmail.com> wrote:
> On Tue, May 23, 2017 at 7:03 AM, Borislav Petkov <bp@suse.de> wrote:
>> On Tue, May 23, 2017 at 07:45:19AM -0600, Jan Beulich wrote:
>>> > --- a/opcodes/i386-opc.tbl
>>> > +++ b/opcodes/i386-opc.tbl
>>>
>>> ... why does the assembler need to know?
>>
>> Probably doesn't. My main goal is to have objdump decode it properly.
>>
>>
> 
> Please submit a new patch without assembler change.

Also (I've just checked with my version) I think if we do this, we
want it for all 6 opcodes (0xC0, 0xC1, 0xD0...0xD3) rather than
just one of them.

Jan
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]