This is the mail archive of the mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH, LD, ping] Make import libraries relocatable objects

On 05/05/17 10:14, Nick Clifton wrote:
Hi Thomas,


Oops - sorry - I was assuming that one of the ARM maintainers would look at this.

Actually this specific patch also needs a global reviewer because it changes the behavior of the target-independent --out-implib feature as well which is why I didn't add the ARM tag in the subject.

*** bfd/ChangeLog ***

2017-04-25  Thomas Preud'homme  <>

    * elflink.c (elf_output_implib): Remove executable flag from import
    library bfd.
    * elf32-arm.c (elf32_arm_filter_implib_symbols): Assert that the import
    library is a relocatable object file.

*** ld/ChangeLog ***

2017-04-25  Thomas Preud'homme  <>

    * testsuite/ld-arm/arm-elf.exp
    (Secure gateway import library generation): Check e_type field
    of import library and executable produced.
    * testsuite/ld-arm/cmse-implib.type: Expectations for e_type field.

Testing: testsuite shows no regression when run for arm-none-eabi and

Is this ok for master?

Approved - please apply, but, please could you make one small change:

+  BFD_ASSERT (!(bfd_get_file_flags (info->out_implib_bfd) & EXEC_P));

Please could you add a comment above this assert referencing the ARM ECM
document and explaining why the check is here ?

Will do. Can you confirm you are happy with the target-independent change as well?

Best regards,


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]