This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] PR ld/21382: Handle symbol defined in IR and referenced in DSO
- From: Alan Modra <amodra at gmail dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: binutils at sourceware dot org
- Date: Wed, 19 Apr 2017 10:18:55 +0930
- Subject: Re: [PATCH] PR ld/21382: Handle symbol defined in IR and referenced in DSO
- Authentication-results: sourceware.org; auth=none
- References: <20170414154456.GA22259@intel.com>
On Fri, Apr 14, 2017 at 08:44:56AM -0700, H.J. Lu wrote:
> +++ b/bfd/elflink.c
> + /* Preserve re_def_dynamic_ref so that this symbol will
Comment typo.
> +++ b/include/bfdlink.h
> + /* Symbol is defined in an IR object and referenced in a dynamic
> + object. */
> + unsigned int ir_def_dynamic_ref : 1;
The comment here isn't completely true. The flag will only be set if
the dynamic object is linked *after* the IR object, won't it? I think
it is worth stating that, or fixing your plugin_notice change to also
cover the case where the IR object is linked after a dynamic object.
--
Alan Modra
Australia Development Lab, IBM