This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] [WebAssembly] Disassembler support


Hi Nick,
On Fri, Apr 7, 2017 at 9:32 AM, Nick Clifton <nickc@redhat.com> wrote:
>> +#define DECIMAL_DIG_IEEE754 17
>
> Wouldn't it just be easier to provide a value for DECIMAL_DIG if it is not
> currently defined ?  That way, if it is defined, you can be sure that you
> are getting the correct value for the host system.

I don't think that would be the right thing to do--we want to preserve
WebAssembly's f64s, not host doubles. If our host system provides long
doubles, DECIMAL_DIG might be larger than 17, even though 17 is enough
to represent each IEEE 754 double (i.e. each WebAssembly f64)
uniquely. So forcing it to 17 will do the right thing on hosts where
doubles are good enough to preserve IEEE 754 doubles.

Thanks,
Pip


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]