This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] bfd: Fix Win64 build, rework find_separate_debug_file interface
- From: Nick Clifton <nickc at redhat dot com>
- To: Pedro Alves <palves at redhat dot com>, binutils at sourceware dot org
- Date: Fri, 7 Apr 2017 14:54:02 +0100
- Subject: Re: [PATCH] bfd: Fix Win64 build, rework find_separate_debug_file interface
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx05.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx05.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=nickc at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 523AE19D4D2
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 523AE19D4D2
- References: <1491433853-10934-1-git-send-email-palves@redhat.com>
Hi Pedro,
> gdb/ChangeLog:
> 2017-04-05 Pedro Alves <palves@redhat.com>
>
> * opncls.c (bfd_get_debug_link_info): Rename to...
> (bfd_get_debug_link_info_1): ... this. Change type of second
> parameter to void pointer. Adjust.
> (bfd_get_debug_link_info): Reimplement on top of
> bfd_get_debug_link_info_1.
> (separate_debug_file_exists, separate_alt_debug_file_exists):
> Change type of second parameter to void pointer. Adjust.
> (get_func_type, check_func_type): Change type of second parameter
> to void pointer.
> (find_separate_debug_file): Add 'func_data' parameter. Pass it to
> the callback functions instead of passing the address of a local.
> (bfd_follow_gnu_debuglink): Pass address of unsigned long local to
> find_separate_debug_file.
> (get_alt_debug_link_info_shim): Change type of second parameter to
> void pointer. Adjust.
> (bfd_follow_gnu_debugaltlink): Adjust to pass NULL to
> find_separate_debug_file.
> (get_build_id_name, bfd_boolean check_build_id_file): Change type
> of second parameter to void pointer. Adjust.
> (bfd_follow_build_id_debuglink): Pass address of bfd_build_id
> pointer local to find_separate_debug_file.
Approved and applied.
Cheers
Nick
PS. Thanks for doing this - it is something that I have been meaning to tidy up for some time now...