This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] gdb passes and returns incorrect values when dealing with small array on Sparc


Hi Vladimir,

gdb development happens on a separate list - gdb-patches@.  Please resend
the patch there.  TIA!

A question I'll have is whether this had any observable effect in testsuite
results, other than "no regressions".  I.e., whether there were progressions,
or whether we're missing testsuite coverage.

On 03/28/2017 06:21 PM, vladimir.mezentsev@oracle.com wrote:
> From: Vladimir Mezentsev <vladimir.mezentsev@oracle.com>
> 
> 	gdb has a special type (TYPE_CODE_ARRAY) to support the gcc extension
> 	(https://gcc.gnu.org/onlinedocs/gcc/Vector-Extensions.html).
> 	TYPE_CODE_ARRAY is handled incorrectly for both (32- and 64-bit) modes on Sparc machines.
> 
> 	Tested on sparc64-linux-gnu and sparc-solaris (32- and 64-bit mode).
> 	No regressions.
> 
> 	2017-03-27 Vladimir Mezentsev <vladimir.mezentsev@oracle.com>
> 
> 	* gdb/sparc-tdep.c (sparc_structure_return_p): New function.

Also, please drop "gdb/" here.  Filename entries in ChangeLogs
are relative to the ChangeLog file path.

Thanks,
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]