This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] gdb passes and returns incorrect values when dealing with small array on Sparc
- From: Pedro Alves <palves at redhat dot com>
- To: vladimir dot mezentsev at oracle dot com, binutils at sourceware dot org
- Date: Wed, 29 Mar 2017 10:56:08 +0100
- Subject: Re: [PATCH] gdb passes and returns incorrect values when dealing with small array on Sparc
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 5302E41A53
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 5302E41A53
- References: <1490721669-12560-1-git-send-email-vladimir.mezentsev@oracle.com>
Hi Vladimir,
gdb development happens on a separate list - gdb-patches@. Please resend
the patch there. TIA!
A question I'll have is whether this had any observable effect in testsuite
results, other than "no regressions". I.e., whether there were progressions,
or whether we're missing testsuite coverage.
On 03/28/2017 06:21 PM, vladimir.mezentsev@oracle.com wrote:
> From: Vladimir Mezentsev <vladimir.mezentsev@oracle.com>
>
> gdb has a special type (TYPE_CODE_ARRAY) to support the gcc extension
> (https://gcc.gnu.org/onlinedocs/gcc/Vector-Extensions.html).
> TYPE_CODE_ARRAY is handled incorrectly for both (32- and 64-bit) modes on Sparc machines.
>
> Tested on sparc64-linux-gnu and sparc-solaris (32- and 64-bit mode).
> No regressions.
>
> 2017-03-27 Vladimir Mezentsev <vladimir.mezentsev@oracle.com>
>
> * gdb/sparc-tdep.c (sparc_structure_return_p): New function.
Also, please drop "gdb/" here. Filename entries in ChangeLogs
are relative to the ChangeLog file path.
Thanks,
Pedro Alves