This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] [WebAssembly] Skeleton support


Hi Pip,

> 2017-03-23  Pip Cet  <pipcet@gmail.com>
> 
>     * wasm-module.c: New file to support WebAssembly modules.
>     * wasm-module.h: New file to support WebAssembly modules.
>     * doc/webassembly.texi: Start documenting wasm-module.c.
>     * config.bfd: Add wasm_vec.
>     * targets.c: Likewise.
>     * configure.ac: Likewise.
>     * Makefile.am: Add entries for wasm-module.c.
 
Approved and applied.

One comment I would make is that we prefer sentences inside 
comments to have two spaces after the full stop.  This helps
emacs's sentence parsing code.  But this was not sufficiently
important to hold up approving the patch.

Cheers
  Nick



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]