This is the mail archive of the
mailing list for the binutils project.
RE: [PATCH 1/2] In the ARC assembler we have some special flag handling for the ".t" and ".nt" flags which only really applies to ARCv2, though currently the check is performed for all architectures.
- From: Claudiu Zissulescu <Claudiu dot Zissulescu at synopsys dot com>
- To: Rinat Zelig <rinat at mellanox dot com>, "binutils at sourceware dot org" <binutils at sourceware dot org>
- Cc: "Cupertino dot Miranda at synopsys dot com" <Cupertino dot Miranda at synopsys dot com>, "Noam Camus" <noamca at mellanox dot com>, Andrew Burgess <andrew dot burgess at embecosm dot com>
- Date: Tue, 14 Mar 2017 09:13:22 +0000
- Subject: RE: [PATCH 1/2] In the ARC assembler we have some special flag handling for the ".t" and ".nt" flags which only really applies to ARCv2, though currently the check is performed for all architectures.
- Authentication-results: sourceware.org; auth=none
- References: <email@example.com> <DB6PR0501MB26150D895771D605875F0AC6C5220@DB6PR0501MB2615.eurprd05.prod.outlook.com>
The patch looks good, however, there are a number of small issues which you may like to fix before committing. Please find them inserted
> + Flag operands don't have an architecture field, so we can't
> + directly validate that FLAG_OPERAND is valid for the current
> + architecture, what we do instead is just validate that we're
> + assembling for an ARCv2 architecture. */
It seems to me, you have an extra space after dot. Please correct it.
> + if ((selected_cpu.flags & (ARC_OPCODE_ARCv2EM |0
It will be nice if you can use ARC_OPCODE_ARCV2 macro here.
> + && (!strcmp (flg_operand->name, "t")
> + || !strcmp (flg_operand->name, "nt")))
> unsigned bitYoperand = 0;
> /* FIXME! move selection bbit/brcc in arc-opc.c. */