This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 3/6] DWARF-5 basic functionality

From: Jan Kratochvil <jkratoch at redhat dot com>
To: Nick Clifton <nickc at redhat dot com>
Cc: binutils at sourceware dot org, Victor Leschuk <vleschuk at accesssoftek dot com>
Date: Wed, 22 Feb 2017 19:42:01 +0100
Subject: Re: [PATCH 3/6] DWARF-5 basic functionality
Authentication-results: sourceware.org; auth=none
References: <148719947800.19826.950569475344047705.stgit@host1.jankratochvil.net> <148719949682.19826.2070422036617207800.stgit@host1.jankratochvil.net> <c51c20eb-e40e-5fbb-c0ce-3dfe4da8d7c9@redhat.com>

On Wed, 22 Feb 2017 12:36:18 +0100, Nick Clifton wrote:
> >        if (compunit.cu_version != 2
> >  	  && compunit.cu_version != 3
> > -	  && compunit.cu_version != 4)
> > +	  && compunit.cu_version != 4
> > +	  && compunit.cu_version != 5)
> 
> There are going to be lots of these range checks in readelf now.  You might 
> as well add a macro, eg IN_RANGE(LOW,HIGH), and use that to make the code
> shorter.

As you made it optional I have used:

-      if (compunit.cu_version != 2
-         && compunit.cu_version != 3
-         && compunit.cu_version != 4)
+      if (compunit.cu_version < 2 || compunit.cu_version > 5)


Thanks,
Jan

References:
- [PATCH 1/6] DWARF attrs: add delimiter
  - From: Jan Kratochvil
- [PATCH 3/6] DWARF-5 basic functionality
  - From: Jan Kratochvil
- Re: [PATCH 3/6] DWARF-5 basic functionality
  - From: Nick Clifton

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]