This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH][ARC] Provide an interface to decode ARC instructions.
- From: Nick Clifton <nickc at redhat dot com>
- To: Claudiu Zissulescu <Claudiu dot Zissulescu at synopsys dot com>, binutils at sourceware dot org
- Cc: Francois dot Bedard at synopsys dot com, Anton dot Kolesov at synopsys dot com
- Date: Fri, 3 Feb 2017 12:04:28 +0000
- Subject: Re: [PATCH][ARC] Provide an interface to decode ARC instructions.
- Authentication-results: sourceware.org; auth=none
- References: <1485776832-29856-1-git-send-email-claziss@synopsys.com>
Hi Claudiu,
> gas/
> 2016-11-21 Claudiu Zissulescu <claziss@synopsys.com>
>
> * config/tc-arc.c (parse_opcode_flags): Ignore implicit flags.
>
> include/
> 2016-11-21 Claudiu Zissulescu <claziss@synopsys.com>
> Anton Kolesov <anton.kolesov@synopsys.com>
>
> * opcode/arc.h (insn_class_t): Add ENTER, LEAVE, POP, PUSH, BBIT0,
> BBIT1, BI, BIH, BRCC, EI, JLI, and SUB instruction classes.
> (flag_class_t): Add F_CLASS_WB, F_CLASS_ZZ, and F_CLASS_IMPLICIT
> flag classes.
>
> opcode/
> 2016-11-21 Claudiu Zissulescu <claziss@synopsys.com>
> Anton Kolesov <anton.kolesov@synopsys.com>
>
> * arc-dis.c (arc_disassemble_info): New structure.
> (init_arc_disasm_info): New function.
> (find_format_from_table): Ignore implicit flags.
> (find_format): Update dissassembler private data.
> (print_flags): Likewise.
> (print_insn_arc): Likewise.
> (arc_opcode_to_insn_type): Consider the new added instruction
> classes.
> (arcAnalyzeInstr): Remove.
> (arc_insn_decode): New function.
> * arc-dis.h (arc_ldst_writeback_mode): New enum.
> (arc_ldst_data_size): Likewise.
> (arc_condition_code): Likewise.
> (arc_operand_kind): Likewise.
> (arc_insn_kind): New struct.
> (arc_instruction): Likewise.
> (arc_insn_decode): Declare function.
> (ARC_Debugger_OperandType): Deleted.
> (Flow): Likewise.
> (NullifyMode): Likewise.
> (allOperandsSize): Likewise.
> (arcDisState): Likewise.
> (arcAnalyzeInstr): Likewise.
> * arc-dis.c (arc_opcode_to_insn_type): Handle newly introduced
> insn_class_t enums.
> * arc-opc.c (F_SIZED): New define.
> (C_CC_EQ, C_CC_GE, C_CC_GT, C_CC_HI, C_CC_HS): Likewise.
> (C_CC_LE, C_CC_LO, C_CC_LS, C_CC_LT, C_CC_NE): Likewise.
> (C_CC_NE, C_AA_AB, C_AA_AW, C_ZZ_D, C_ZZ_H, C_ZZ_B): Likewise.
> (arc_flag_classes): Add F_CLASS_COND/F_CLASS_IMPLICIT flags.
> * opcodes/arc-tbl.h: Update instructions to include new
> F_CLASS_IMPLICIT flags.
> (bbit0, lp): Change class.
> (bbit1, bi, bih, br*, ei_s, jli_s): Likewsie
Approved - please apply - although, please could you fix up the indentation in opcodes/arc-dis.h.
The check for being included by a C++ compiler should not affect the indentation of the lines that follow...
Cheers
Nick