This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH 1/2] Add support for setting disassembler-options in GDB for POWER, ARM and S390
- From: Yao Qi <qiyaoltc at gmail dot com>
- To: Peter Bergner <bergner at vnet dot ibm dot com>
- Cc: Pedro Alves <palves at redhat dot com>, Eli Zaretskii <eliz at gnu dot org>, Nick Clifton <nickc at redhat dot com>, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>, Ulrich Weigand <uweigand at de dot ibm dot com>, Alan Modra <amodra at gmail dot com>, Binutils <binutils at sourceware dot org>
- Date: Wed, 1 Feb 2017 21:44:45 +0000
- Subject: Re: [PATCH 1/2] Add support for setting disassembler-options in GDB for POWER, ARM and S390
- Authentication-results: sourceware.org; auth=none
- References: <b6037acd-9036-7e69-3350-8da5f0ec981b@vnet.ibm.com> <bdc0c318-4abd-010e-28cf-b654222fe86a@redhat.com> <decc5b05-46eb-2187-5cbd-a7a2a32aaa56@vnet.ibm.com> <83eg28dcjk.fsf@gnu.org> <019eaf5d-9ace-539e-8501-feb3cb0eed6c@vnet.ibm.com> <a1d6f084-4ae2-66a1-3a1b-1a3072b87a0b@redhat.com> <ddaefb9f-9c11-655d-679c-a242bea2c10d@vnet.ibm.com> <20170125142335.GT28060@E107787-LIN> <e5b34906-4aa8-46fd-633d-f918125da5e6@vnet.ibm.com>
On 17-01-31 15:13:29, Peter Bergner wrote:
> >> void
> >> print_arm_disassembler_options (FILE *stream)
> >> {
> >
> > print_arm_disassembler_options can be adjusted as what you changed to
> > print_s390_disassembler_options, otherwise, we may have inconsistency
> > in the future.
>
> Can you be more specific about what I did to the s390 code you want
> done to the arm code? I'll note I have changed things due to Alan
> wanting the strings to support internationalization.
>
Right, you changed it in
https://sourceware.org/ml/binutils/2017-01/msg00432.html
That is exactly what I wanted. Thanks.
--
Yao