This is the mail archive of the mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Fix PR 20995 for cris-linux (please have a look)

On Fri, Jan 27, 2017 at 01:54:11AM +0100, Hans-Peter Nilsson wrote:
> Hi.  I grew tired of waiting for the new failing test-case to
> magically start working for cris-linux and had a look at PR20995
> myself - or rather, just the changes in 5474d94f03aedb.  It
> looks like the pattern of solutions for most other targets can
> be followed, modulo elf32-cris.c not being "converted over to
> use the new dynamic sections for read-only variables".
> This patch being the moral equivalent of a copy-paste of changes
> in that commit, I'm not over-confident despite all tests now
> passing.  Can I ask you to please have a quick look at the following?
> Thanks in advance.

It looks fine, but please do a little more work on your target and
convert over to using the hash table shortcuts everywhere possible.

> @@ -3787,7 +3797,8 @@ elf_cris_size_dynamic_sections (bfd *output_bfd ATTRIBUTE_UNUSED,
>  	    }
>  	}
>        else if (! CONST_STRNEQ (name, ".got")
> -	       && strcmp (name, ".dynbss") != 0)
> +	       && strcmp (name, ".dynbss") != 0
> +	       && s != htab->root.sdynrelro)

This example of code in elf_cris_size_dynamic_sections is why I didn't
convert cris at the same time I did other targets.  You're not using
the shortcuts to .dynbss or .got and seem to be doing something weird
in checking for ".got*".  When I'm working on non-vital changes for
lots of targets it doesn't take much oddity in the target for me to
leave the fix to the target maintainer, assuming the target has a

Alan Modra
Australia Development Lab, IBM

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]