This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 4/5] Solaris2/LD: Fix anonymous version script acceptance bug

From: "Maciej W. Rozycki" <macro at imgtec dot com>
To: Alan Modra <amodra at gmail dot com>
Cc: Nick Clifton <nickc at redhat dot com>, Tristan Gingold <gingold at adacore dot com>, James Cowgill <James dot Cowgill at imgtec dot com>, "Maciej W. Rozycki" <macro at linux-mips dot org>, <binutils at sourceware dot org>
Date: Tue, 24 Jan 2017 14:09:37 +0000
Subject: Re: [PATCH 4/5] Solaris2/LD: Fix anonymous version script acceptance bug
Authentication-results: sourceware.org; auth=none
References: <bug-20828-70@http.sourceware.org/bugzilla/> <bug-20828-70-QMcZ2LkAaY@http.sourceware.org/bugzilla/> <e6ca2026-eead-8e4a-b99b-dba27c41ac0d@redhat.com> <alpine.DEB.2.00.1701191811170.6936@tp.orcam.me.uk> <alpine.DEB.2.00.1701202112480.6936@tp.orcam.me.uk> <alpine.DEB.2.00.1701221451170.13564@tp.orcam.me.uk> <20170124005625.GE28669@bubble.grove.modra.org>

On Tue, 24 Jan 2017, Alan Modra wrote:

> > 	* emultempl/solaris2.em (elf_solaris2_before_allocation): Do not
> > 	add implicit version nodes if any existing version information 
> > 	has no name.
> 
> OK, but suggest you change the above to "..nodes if anonymous version
> tag is being used".  "any existing version information has no name"
> implies a search over all tags to me (which of course isn't needed due
> to the restriction in lang_register_vers_node).

 Right, I used "any" in the sense of "if there is", however I agree your 
proposed wording is clearer.  Thanks, applied now, with the entry updated.

  Maciej

References:
- Re: [Bug ld/20828] GC-ed DSO symbols make corresponding symbols defined by a linker script local
  - From: Maciej W. Rozycki
- [PATCH 0/5][Bug ld/20828] GC-ed DSO symbols make corresponding symbols defined by a linker script local
  - From: Maciej W. Rozycki
- [PATCH 4/5] Solaris2/LD: Fix anonymous version script acceptance bug
  - From: Maciej W. Rozycki
- Re: [PATCH 4/5] Solaris2/LD: Fix anonymous version script acceptance bug
  - From: Alan Modra

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]