This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] objdump: Better objdump section headers in wide mode


* Alan Modra <amodra@gmail.com> [2017-01-19 10:27:55 +1030]:

> I like the patch but you didn't say how it was tested.  That leads me
> to suspect the patch may introduce testsuite regressions.  A grep over
> the testsuite shows occurrences of "objdump -hw" and
> "objdump -h --wide" in target specific tests.

Apologies.  I ran the patch against ~200 different build targets, most
just configured with --target=BLAH, but a few also built using -m32 in
the CFLAGS (including native x86-64 with --targets=all and -m32 in the
CFLAGS).

There was one failure, which I fixed in the patch, but otherwise it
was all fine.

I'd love to hear about any regressions, so I can increase my test
coverage, but otherwise I think I'm as confident in this as I can be.

Thanks,
Andrew


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]