This is the mail archive of the
mailing list for the binutils project.
Re: [GOLD] Fix tests for powerpc64
- From: Cary Coutant <ccoutant at gmail dot com>
- To: Alan Modra <amodra at gmail dot com>
- Cc: Binutils <binutils at sourceware dot org>
- Date: Mon, 9 Jan 2017 09:05:29 -0800
- Subject: Re: [GOLD] Fix tests for powerpc64
- Authentication-results: sourceware.org; auth=none
- References: <20170107125231.GS31129@bubble.grove.modra.org>
> PowerPC64 defines .TOC. rather than _GLOBAL_OFFSET_TABLE_, and
> what's more, doesn't define it at all unless referenced. For ELFv1
> ABI the symbol isn't normally referenced, so modify the test to accept
> .TOC. as a variant of _GLOBAL_OFFSET_TABLE_ and 0 or 1 occurrences.
> copy_test_relro as written doesn't need copy relocs on PowerPC64.
> PowerPC64 is always PIC. So, modify copy_test_relro to test that the
> existing vars are in fact read-only directly by deliberately causing a
> sigsegv, and add another couple of vars that do cause copy relocs even
> when PIC.
> * testsuite/ver_test_8.sh: Accept .TOC. in lieu of
> _GLOBAL_OFFSET_TABLE_. Allow zero count.
> * testsuite/copy_test_relro_1.cc (c, q): New vars.
> * testsuite/copy_test_relro.cc: Rewrite to test read-only
> status of variables directly. Reference new vars in
> read-only data.
Sorry, my original intent was to accept the non-copy-relocation case
where the variables remained in the shared library, but I kind of lost
track of that when I got around to writing the test. I like your
straightforward approach of just testing that the variables remain
This is OK. Thanks!