This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH 1/5] Add support for the RISC-V Q extension
- From: Palmer Dabbelt <palmer at dabbelt dot com>
- To: nickc at redhat dot com
- Cc: binutils at sourceware dot org
- Cc: kito dot cheng at gmail dot com
- Cc: gingold at adacore dot com
- Cc: Andrew Waterman <andrew at sifive dot com>
- Cc: amorda at gmail dot com
- Date: Tue, 03 Jan 2017 10:54:53 -0800 (PST)
- Subject: Re: [PATCH 1/5] Add support for the RISC-V Q extension
- Authentication-results: sourceware.org; auth=none
On Tue, 03 Jan 2017 09:45:59 PST (-0800), nickc@redhat.com wrote:
> Hi Palmer, Hi Kito,
>
>> gas/ChangeLog
>>
>> 2016-12-21 Kito Cheng <kito.cheng@gmail.com>
>>
>> * config/tc-riscv.c (riscv_set_arch): Whitelist the "q" ISA
>> extension.
>> (riscv_after_parse_args): Set FLOAT_ABI_QUAD when the Q ISA is
>> enabled and no other ABI is specified.
>>
>> include/ChangeLog
>>
>> 2016-12-21 Kito Cheng <kito.cheng@gmail.com>
>>
>> * opcode/riscv-opc.h: Add support for the "q" ISA extension.
>>
>> opcodes/ChangeLog
>>
>> 2016-12-21 Kito Cheng <kito.cheng@gmail.com>
>>
>> * riscv-opc.c (riscv-opcodes): Add support for the "q" ISA
>> extension.
>> * riscv-opcodes/all-opcodes: Likewise.
>
> Approved and applied to the mainline sources.
Thanks! This was part of a patch set, does your statement apply to all 5
patches or just the first one?
> Unfortunately now that the 2.28 branch has been created you need approval
> from the branch maintainer (Tristan Gringold, CC'ed) before the patch can
> be checked in there.
OK, I'll do that in the future.
> Cheers
> Nick
>
> PS. Sorry for the delay in reviewing these patches. I know that you wanted
> to get them in to the mainline sources before the 2.28 branch happened. You
> just picked an unfortunate time of year when I was on holiday...
It's fine, these changes are all pretty self-contained so I don't mind
maintaining both branches (it was essentially zero work for these).