This is the mail archive of the mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v2 00/15] Binutils/gas/ld port for PRU

On Tue, Dec 27, 2016 at 10:43:35PM +0200, Dimitar Dimitrov wrote:
> I hope I have addressed all comments from the initial submission.

This all looks good, with the exception of bfd/cpu-pru.c and
gas/doc/c-pru.texi which need 2016 to be mentioned in their copyright
notices.  OK to apply with that fixed.  There are a few whitespace
errors too, which can be fixed now or later.  Shown by adding
whitespace = indent-with-non-tab,space-before-tab,trailing-space
to your binutils .git/config.

git am ~/Mail/dimitar
Applying: PRU BFD support
.git/rebase-apply/patch:1535: indent with spaces.
	         Set a regular LDI relocation for the first instruction
warning: 1 line adds whitespace errors.
Applying: PRU Binutils port
Applying: PRU GAS Port
.git/rebase-apply/patch:2893: trailing whitespace.
.git/rebase-apply/patch:2898: trailing whitespace.
.git/rebase-apply/patch:2901: trailing whitespace.
# Foundation, Inc., 51 Franklin Street - Fifth Floor, Boston, MA 02110-1301, USA.  
.git/rebase-apply/patch:2909: trailing whitespace.
.git/rebase-apply/patch:2868: new blank line at EOF.
warning: 5 lines add whitespace errors.
Applying: PRU LD Port
.git/rebase-apply/patch:692: indent with spaces.
.git/rebase-apply/patch:693: indent with spaces.
        loop foo, r20
.git/rebase-apply/patch:812: trailing whitespace.
 [0-9a-f]+ e0e0e012 e0e0e012                    ........        
.git/rebase-apply/patch:814: trailing whitespace.
 0000 00000000                             ....            
.git/rebase-apply/patch:864: trailing whitespace.
warning: squelched 10 whitespace errors
warning: 15 lines add whitespace errors.
Applying: PRU Opcode Port
.git/rebase-apply/patch:146: indent with spaces.
                                   instruction.  */
.git/rebase-apply/patch:571: indent with spaces.
                       disassemble_info *info)
.git/rebase-apply/patch:603: indent with spaces.
         can reuse some code.  */
warning: 3 lines add whitespace errors.

Some of these of course can't be fixed.  Testcase .d files and similar
must match the tool output.

Alan Modra
Australia Development Lab, IBM

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]