This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH, RFA] opcodes: Use autoconf to check for `bfd_mips_elf_get_abiflags' in BFD

From: "Maciej W. Rozycki" <macro at imgtec dot com>
To: Alan Modra <amodra at gmail dot com>
Cc: <binutils at sourceware dot org>
Date: Fri, 23 Dec 2016 20:44:56 +0000
Subject: Re: [PATCH, RFA] opcodes: Use autoconf to check for `bfd_mips_elf_get_abiflags' in BFD
Authentication-results: sourceware.org; auth=none
References: <E1cHNui-0007Mp-46@kwanyin.sergiodj.net> <alpine.DEB.2.00.1612150502490.6743@tp.orcam.me.uk> <wwok1sx9nhet.fsf@ericsson.com> <alpine.DEB.2.00.1612151946340.6743@tp.orcam.me.uk> <20161215230316.GM10584@bubble.grove.modra.org> <alpine.DEB.2.00.1612152309200.6743@tp.orcam.me.uk> <alpine.DEB.2.00.1612191144230.6743@tp.orcam.me.uk> <20161222123958.GA2896@bubble.grove.modra.org> <alpine.DEB.2.00.1612222017020.6743@tp.orcam.me.uk> <20161223140106.GE2896@bubble.grove.modra.org>

On Fri, 23 Dec 2016, Alan Modra wrote:

> > 	* mips-dis.c (set_default_mips_dis_options): Use 
> > 	HAVE_BFD_MIPS_ELF_GET_ABIFLAGS rather than BFD64 to guard the
> > 	call to `bfd_mips_elf_get_abiflags'.
> > 	* configure.ac: Check for `bfd_mips_elf_get_abiflags' in BFD.
> > 	* Makefile.am (CONFIG_STATUS_DEPENDENCIES): Add `libbfd.la'.
> > 	* aclocal.m4: Regenerate.
> > 	* configure: Regenerate.
> > 	* config.in: Regenerate.
> > 	* Makefile.in: Regenerate.
> 
> Looks OK to me.

 Great, thanks for a quick review!  Applied now and backported to 2.28.

  Maciej

References:
- Re: Your commit 'MIPS/opcodes: Also set disassembler's ASE flags from ELF structures' broke GDB
  - From: Maciej W. Rozycki
- Re: Your commit 'MIPS/opcodes: Also set disassembler's ASE flags from ELF structures' broke GDB
  - From: Alan Modra
- Re: Your commit 'MIPS/opcodes: Also set disassembler's ASE flags from ELF structures' broke GDB
  - From: Maciej W. Rozycki
- Re: Your commit 'MIPS/opcodes: Also set disassembler's ASE flags from ELF structures' broke GDB
  - From: Maciej W. Rozycki
- [PATCH, RFA] opcodes: Use autoconf to check for `bfd_mips_elf_get_abiflags' in BFD
  - From: Maciej W. Rozycki
- Re: [PATCH, RFA] opcodes: Use autoconf to check for `bfd_mips_elf_get_abiflags' in BFD
  - From: Alan Modra

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]