This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Don't call "error" in sysroot-prefix.exp
- From: Alan Modra <amodra at gmail dot com>
- To: binutils at sourceware dot org
- Date: Thu, 22 Dec 2016 15:21:47 +1030
- Subject: Don't call "error" in sysroot-prefix.exp
- Authentication-results: sourceware.org; auth=none
We don't want to report a test failure as a tcl error.
* testsuite/ld-scripts/sysroot-prefix.exp (sysroot_prefix_test_setup):
Call perror rather than error on "as" or "ar" failures.
diff --git a/ld/testsuite/ld-scripts/sysroot-prefix.exp b/ld/testsuite/ld-scripts/sysroot-prefix.exp
index 47d0657..8c24471 100644
--- a/ld/testsuite/ld-scripts/sysroot-prefix.exp
+++ b/ld/testsuite/ld-scripts/sysroot-prefix.exp
@@ -81,7 +81,7 @@ proc sysroot_prefix_test_setup { } {
global as gasopt srcdir subdir ar
if {![ld_assemble_flags $as $gasopt $srcdir/$subdir/pr14962a.s tmpdir/main.o]} {
- error "Error assembling a trivial file for sysroot-prefix tests framework"
+ perror "Error assembling a trivial file for sysroot-prefix tests framework"
return 0
}
@@ -106,13 +106,13 @@ proc sysroot_prefix_test_setup { } {
set libnamebase [lindex $test_object 2]
if ![ld_assemble_flags $as $gasopt $srcdir/$subdir/$sname $oname] {
- error "Error assembling trivial file $sname for sysroot-prefix tests framework"
+ perror "Error assembling trivial file $sname for sysroot-prefix tests framework"
return 0
}
if { [string length $libnamebase] != 0 &&
![ar_simple_create $ar "" tmpdir/sysroot/tmp/ldtest-xyzzy/lib$libnamebase.a $oname] } {
- error "Error creating archive $libnamebase for sysroot-prefix tests framework"
+ perror "Error creating archive $libnamebase for sysroot-prefix tests framework"
return 0
}
}
--
Alan Modra
Australia Development Lab, IBM